Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Maintain aspect ratio for the Campaign Cover Image block #7718

Open
wants to merge 2 commits into
base: epic/campaigns
Choose a base branch
from
Open

Fix: Maintain aspect ratio for the Campaign Cover Image block #7718

wants to merge 2 commits into from
+6 −8

Conversation

kjohnson
Copy link
Member

@kjohnson kjohnson commented Feb 7, 2025 •
edited
Loading

Resolves GIVE-2147

Description

This PR updates the Campaign Cover block to maintain the apsect ratio when used inside of a <ResizerBox>.

Visuals

Peek 2025-02-07 13-30

Testing Instructions

Create a Campaign and edit the Campaign Page with a Campaign Cover block. Resize the image.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@kjohnson kjohnson marked this pull request as ready for review February 7, 2025 18:55
jonwaldstein
jonwaldstein approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! this definitely solves the squishy-ness 🦑 lol just added one suggestion for adding extra escaping

src/Campaigns/Blocks/CampaignCover/render.php
Comment on lines +38 to +39
<?php echo $widthStyle ?>
<?php echo $heightStyle; ?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add escaping to these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonwaldstein jonwaldstein jonwaldstein approved these changes

@JoshuaHungDinh JoshuaHungDinh Awaiting requested review from JoshuaHungDinh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjohnson @jonwaldstein