[BUGFIX] Fix publishbackgroundall dependency index #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command in2publish:workflow:publishbackground from the premium
plugin may skip pages depending on previous pages:
1. Assume a page and a child page are scheduled for publishing.
2. Assume the child page gets processed first.
3. The child page will fetch the parent page as a dependency. The
parent page will get recorded in the index.
4. When the parent page record gets fetched from the database, it will
already be in the index. It will not get added to any record index
recording.
5. The RecordTreeBuilder assumes that pages scheduled for publishing
get added to the record index recording buildRecordTree, which did
not happen in step 4.
6. The parent page gets marked as published, but changes will not
actually have been published.
This commit ensures the parent page gets added to the buildRecordTree
record index recording. It archives that by adding pages to the record
index recording even if it was already in the index.
As this code is pretty deep, I am not quite sure about unintended side
effects. Intense testing is advisable.
|
Thank you very much for supplying this helpful PR. |
|
We could reproduce the problem and tested the PR successfully. Thanks for your investigation and support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command in2publish:workflow:publishbackground from the premium plugin may skip pages depending on previous pages:
This commit ensures the parent page gets added to the buildRecordTree record index recording. It archives that by adding pages to the record index recording even if it was already in the index.
As this code is pretty deep, I am not quite sure about unintended side effects. Intense testing is advisable.