Support large tables in addSitesUpgradeWizard #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removes duplicate code * do not load the complete tables in memory * less queries using group by pages * delete records without relation to page * update only records with empty site Resolves: in2code-de#62
|
Thx for digging into this issue. Did you run the upgrade wizard from CLI or from Browser (via Install Tool)? I'm asking because I think that running from CLI should be possible no matter how long it would take. Even if your solution is a good thing, it might need some time in testing for me. And currently the TYPO3 13 update is our main focus for LUX, LUXenterprise and LUXletter |
|
The main issue is not about the long running, but loading the complete table in memory, so a memory limit issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.