Update dependencies during transformation #279
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… inames from dependencies when removing unused inames
…tiple vars at once; don't try to split inames in dependencies that don't contain that iname
This was referenced Apr 11, 2021
…ncies-during-transformation
…(maps individual dep maps); create map_stmt_inst_dependencies() (maps stmt.dependencies, which contains multiple dep maps)
…e instructions (for now)
…l stmts where its subst expr was used
…tch all usage sites
…er and dependee statements; create map_dependency_lists(); rename map_stmt_inst_dependency_maps()->map_dependency_maps(); rename map_stmt_inst_dependencies()->map_stmt_dependencies()
…-during-transformation
… is/will be used; rename to _find_and_rename_dim
…sformation branch a second parent branch (the new map-domain-transformation-v2)
jdsteve2
changed the base branch from
add-map-domain-transformation
to
check-new-dependencies-against-sio
… and simplify code that checks for overlap between the transform map and dependencies
…during-transformation
…ncies-during-transformation
…rticular dim type
…rticular dim type
…nery (find_unsatisfied_dependencies gets new arg 'stop_on_first_violation', add_dependency_v2->add_dependency with tuple arg, find_and_rename_dim->find_and_rename_dims)
…ncies-during-transformation
…ncies-during-transformation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where @jdsteve2 left off: Just merged callables update and some new SIO changes related to dependent iname domains (e.g., 'triangular' domains). Callables test is failing, so there may need to be some fixes related to that update.
This branch had two parents, but one has been merged.
(PR currently just for comparison.)
Transformations where deps need to be updated:
remove_unused_inamesfix_parameterssplit_inameduplicate_inamesmap_domainmap_domaingets more functionalityrename_inameadd_barrierassignment_to_substTransformations where deps don't need to be changed:
prioritize_loopstag_inamesextract_substdoesn't actually change instructions on its own, so any related updates to deps should happen outside ofextract_subst, right?expand_subst?tag_array_axessplit_array_dim"next" (downstream) PR in chain