Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tugger-wix: Add option to add start menu shortcut. #714

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andrewleech
Copy link

@andrewleech andrewleech commented Jul 19, 2023

This MR adds an msi option to create/install a start menu shortcut for the installed application.

So can be used like:

def make_msi(exe):
    msi = exe.to_wix_msi_builder(
        "wsl_usb_gui",
        "WSL USB",
        VARS.get("version"),
        "Andrew Leech"
    )
    msi.add_to_start_menu = True

Note: My work on the set of PR's I've recently openned here are the first time I've ever used rust... this this PR the biggest. I'm sure some of my variable / mut handling is wrong or at least non-ideal, so certainly open to suggestion on how to clean this up a bit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants