Skip to content

Commit

Permalink
feat: move parsing scripts for support matrix to top-level dir (subst…
Browse files Browse the repository at this point in the history
…rait-io#188)

This PR moves the scripts that parse the CSV output of pytest to derive
the support matrix to the new top-level directory `scripts`.

Signed-off-by: Ingo Müller <[email protected]>
  • Loading branch information
ingomueller-net authored Dec 19, 2024
1 parent ac4367f commit c3c50f4
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/support_matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
- name: Parse results
run: |-
python substrait_consumer/tests/functional/extension_functions/parse_${{ matrix.target }}r_pytest_output.py \
python scripts/parse_${{ matrix.target }}r_pytest_output.py \
--input ${{ matrix.target }}r_pytest_output.csv \
--output app/${{ matrix.target }}r_results.csv
Expand Down
23 changes: 14 additions & 9 deletions SUPPORT_MATRIX.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,16 @@ Substrait Producer and Consumer Function Support

## How to regenerate producer test results
```commandline
cd substrait_consumer/tests/functional/extension_functions
# Run the producer tests to create the pytest result output.
pytest --tb=no --csv producer_pytest_output.csv --csv-delimiter ';' --csv-columns 'id,status' -m produce_substrait_snapshot
pytest -v --tb=no \
-m produce_substrait_snapshot \
-k "function/ or ibis_expressions" \
substrait_consumer/ \
--csv producer_pytest_output.csv --csv-delimiter ';' \
--csv-columns 'id,status,properties_as_columns'
# Parse pytest output. This creates a new csv file with the parsed results, which
# the streamlit app uses to generate the table.
python parse_producer_pytest_output.py producer_results.csv
python scripts/parse_producer_pytest_output.py producer_results.csv
```


Expand All @@ -28,13 +30,16 @@ python parse_producer_pytest_output.py producer_results.csv

## How to regenerate consumer test results
```commandline
cd substrait_consumer/tests/functional/extension_functions
# Run the consumer tests to create the pytest result output.
pytest --tb=no --csv consumer_pytest_output.csv --csv-delimiter ';' --csv-columns 'id,status' -m consume_substrait_snapshot
pytest -v --tb=no \
-m consume_substrait_snapshot \
-k "function/ or ibis_expressions" \
substrait_consumer/ \
--csv consumer_pytest_output.csv --csv-delimiter ';' \
--csv-columns 'id,status,properties_as_columns'
# Parse pytest output. This creates a new csv file with the parsed results, which
# the streamlit app uses to generate the table.
python parse_consumer_pytest_output.py consumer_results.csv
python scripts/parse_consumer_pytest_output.py consumer_results.csv
```

File renamed without changes.
File renamed without changes.
Empty file.

0 comments on commit c3c50f4

Please sign in to comment.