Skip to content

Commit

Permalink
ci: run all matrix jobs to the end even if others fail
Browse files Browse the repository at this point in the history
PR substrait-io#132 changed the definition of Github CI workflows to use the
`matrix` feature. If not changed explicitly, the different variants in
the matrix are cancelled as soon as the first variant fails. This
currently prevents us from knowing which of the systems pass CI. This PR
thus sets `fail-fast: false` in order to let all variants in the matrix
to run to completion.

Signed-off-by: Ingo Müller <[email protected]>
  • Loading branch information
ingomueller-net committed Nov 29, 2024
1 parent 915c889 commit c87ee03
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ jobs:
name: Run consumer tests
runs-on: ubuntu-22.04
strategy:
fail-fast: false
matrix:
consumer: [datafusion, duckdb]
steps:
Expand All @@ -35,6 +36,7 @@ jobs:
name: Run producer tests
runs-on: ubuntu-22.04
strategy:
fail-fast: false
matrix:
producer: [datafusion, duckdb, ibis, isthmus]
steps:
Expand Down

0 comments on commit c87ee03

Please sign in to comment.