Add angstrom-eio #227
Open
Add angstrom-eio #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrondin
commented
Jun 11, 2023
| @@ -0,0 +1,20 @@ | |||
| opam-version: "2.0" | |||
| maintainer: "Simon Grondin" | |||
SGrondin
force-pushed
the
angstrom-eio
branch
2 times, most recently
from
b7ee038 to
137d5ba
Compare
|
cc @talex5 I think you had some 'eio' optimizations too, but adding some minimal support for 'eio' first is probably best |
My angstrom-eio branch rewrites everything to use effects, but that loses support for OCaml 4 and Lwt, so it's unlikely to be merged any time soon. |
SGrondin
force-pushed
the
angstrom-eio
branch
from
0b6fc00 to
1a96194
Compare
SGrondin
force-pushed
the
angstrom-eio
branch
from
1a96194 to
208d834
Compare
|
@seliopou I've updated it for Eio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new Eio concurrency library.
Eio is a modern concurrency library. Notably, it leverages OCaml 5's native concurrency support, solves the colored function problem, and uses Io_uring -when available- to achieve impressive performance numbers.
The interface of angstrom-eio closely matches that of angstrom-lwt-unix.
Note: I did not update
.github/workflows/test.ymlbecause I'm unsure how you'd like to update it, since angstrom-eio requires OCaml 5.0.0