Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of phpstan #57

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Introduction of phpstan #57

wants to merge 5 commits into from

Conversation

Chrico
Copy link
Member

@Chrico Chrico commented Jan 17, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This PR will replace "phpcs" with "phpstan" (level 8!) and adds additional extensions for phpstan/phpstan-deprecation-rules´ and swissspidy/phpstan-no-private`.

@Chrico Chrico requested review from tfrommen and gmazzap January 17, 2025 14:24
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.23%. Comparing base (c79bb36) to head (7687fce).

Files with missing lines Patch % Lines
src/Container/ServiceExtensions.php 66.66% 2 Missing ⚠️
src/Properties/LibraryProperties.php 88.88% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #57      +/-   ##
============================================
- Coverage     98.84%   98.23%   -0.61%     
  Complexity      251      251              
============================================
  Files            10       10              
  Lines           607      624      +17     
============================================
+ Hits            600      613      +13     
- Misses            7       11       +4     
Flag Coverage Δ
unittests 98.23% <88.88%> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant