Remove support for deprecated default modules #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This is a follow-up (alternative) to #53.
Currently, this code results in failing tests. However, there was also a bug in the test logic, masking other issues. Considering that there was no change to production, except for the removal of default module handling in
boot, I would argue that the expectations in some failing tests are incorrect, and should be reviewed and fixed.What is the current behavior? (You can also link to an open issue here)
Default modules passed to the
bootmethod are being handled.What is the new behavior (if this is a feature change)?
The
bootmethod does no longer support passing default modules.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: