Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npm as default package manager #152

Merged
merged 15 commits into from
Oct 2, 2024
Merged

Conversation

meszarosrob
Copy link
Member

@meszarosrob meszarosrob commented Aug 21, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refactor

What is the current behavior? (You can also link to an open issue here)
Yarn is used as the default package manager.

What is the new behavior (if this is a feature change)?
Npm is used as the default package manager. A deprecation warning is displayed for those using the PACKAGE_MANAGER input.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
There may be instances where this can cause issues since Yarn and npm are not fully interchangeable.
In such cases, the users can choose to explicitly set the PACKAGE_MANAGER to yarn.

Other information:
Based on the AT decision.

Copy link
Member

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! LGTM. Left two minor comments that don't stop me from approving.

docs/archive-creation.md Show resolved Hide resolved
docs/ddev-playwright.md Outdated Show resolved Hide resolved
Copy link
Member

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

docs/archive-creation.md Show resolved Hide resolved
@tyrann0us tyrann0us marked this pull request as ready for review September 5, 2024 06:47
@tyrann0us tyrann0us merged commit ea75eb2 into main Oct 2, 2024
2 checks passed
@tyrann0us tyrann0us deleted the AT-645-use-npm-as-default branch October 2, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants