Feat/153 make build and push always sync #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrico
approved these changes
Aug 27, 2024
tyrann0us
requested changes
Aug 27, 2024
…e do not move tag
shvlv
approved these changes
Sep 2, 2024
tyrann0us
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR changes a bit the concept of build and push by adding "sync".
Closes #153
What is the current behavior? (You can also link to an open issue here)
We have realized that we prefer to always push the latest changes to the targeted branch/tag.
When we introduced a change in the development branch but didn't generate a difference in the build, the workflow was not updating the release branch because the push was not happening due to a condition. This is a problem when trying to create a version that doesn't change any assets.
What is the new behavior (if this is a feature change)?
This change will run the git push when the workflow is triggered on a branch, ensuring we have the latest changes in the release branch.
When it comes to the tag workflow it behaves a bit differently. We are avoiding moving the tag too much times by checking if there are assets changes.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
It is hard to say, I would say no, it just behaves differently.
Other information: