Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mergify: add mergify configuration #114

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

nathan-weinberg
Copy link
Member

This PR does the following:

  • Adds the following Mergify automation
    • Auto-merging PRs with 2 approving reviews and successful CI
    • Auto-labeling for PRs that touch certain files
  • Updates lint action
    • Hardens several steps
    • Aligns moreso to the CLI repo

Signed-off-by: Nathan Weinberg <[email protected]>
@nathan-weinberg nathan-weinberg requested a review from a team August 28, 2024 14:04
@nathan-weinberg nathan-weinberg linked an issue Aug 28, 2024 that may be closed by this pull request
Copy link
Contributor

@bjhargrave bjhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise it looks fine.

.github/mergify.yml Outdated Show resolved Hide resolved
.github/mergify.yml Outdated Show resolved Hide resolved
.github/mergify.yml Show resolved Hide resolved
@@ -28,7 +28,6 @@ permissions:

jobs:
spellcheck:
name: Spellcheck (en_US)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you explain this deletion?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nathan-weinberg nathan-weinberg merged commit eaa977d into instructlab:main Aug 28, 2024
12 checks passed
@nathan-weinberg nathan-weinberg deleted the mergify branch August 28, 2024 16:14
@mergify mergify bot added the CI/CD Affects CI/CD configuration label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Affects CI/CD configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introuduce merge automation via Mergify
5 participants