Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: move E2E runner from github to AWS #118

Merged
merged 1 commit into from
Aug 29, 2024
Merged

ci: move E2E runner from github to AWS #118

merged 1 commit into from
Aug 29, 2024

Conversation

nathan-weinberg
Copy link
Member

Resolves #104

@nathan-weinberg nathan-weinberg requested review from RobotSail and a team August 29, 2024 12:52
@mergify mergify bot added the CI/CD Affects CI/CD configuration label Aug 29, 2024
@alimaredia
Copy link
Contributor

@nathan-weinberg can you send a run triggered by hand that shows that these new runners work?

@nathan-weinberg
Copy link
Member Author

@nathan-weinberg can you send a run triggered by hand that shows that these new runners work?

I have no way of doing that, you can looking at the Training implementation for reference

@RobotSail
Copy link
Member

@nathan-weinberg @alimaredia You have to merge it first before you can actually test it

@alimaredia
Copy link
Contributor

Ack, in the past there was another repo we used to test new runners. But we can make modifications as needed.

@mergify mergify bot added the one-approval label Aug 29, 2024
@mergify mergify bot removed the one-approval label Aug 29, 2024
@nathan-weinberg nathan-weinberg removed the request for review from RobotSail August 29, 2024 14:28
@nathan-weinberg
Copy link
Member Author

Since the Mergify config changes to require an E2E run that hasn't begun running yet, need to merge this manually

@nathan-weinberg nathan-weinberg merged commit b4ca296 into instructlab:main Aug 29, 2024
7 checks passed
@nathan-weinberg nathan-weinberg deleted the aws-runner branch August 29, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimaredia alimaredia alimaredia approved these changes

@danmcp danmcp danmcp approved these changes

Assignees
No one assigned
Labels
CI/CD Affects CI/CD configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert E2E job to use AWS runners
4 participants
@nathan-weinberg @alimaredia @RobotSail @danmcp