Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ragas version #212

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Conversation

alimaredia
Copy link
Contributor

Before ragas v0.2.11 RubricScores.rubrics wasn't being applied properly. This commit sets that as the minimum version for this library.

A change in v0.2.11 from previous versions was a change in the prompt for domain specific knowledge evaluation with reference. The prompt from previous versions is now explicitly passed in.

@mergify mergify bot added the dependencies Pull requests that update a dependency file label Jan 18, 2025
@alimaredia alimaredia requested a review from RobotSail January 18, 2025 04:43
Copy link
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @alimaredia. I feel like we shouldn't force the old template to be used. Maybe we should allow the legacy template to be used with some kind of legacy flag?

Before ragas v0.2.11 RubricScores.rubrics wasn't
being applied properly. This commit sets that
as the minimum version for this library.

A change in v0.2.11 from previous versions was a
change in the prompt for domain specific knowledge
evaluation with reference.

The new prompt is hardcoded in case ragas makes
any changes to their prompts again in the future.

Signed-off-by: Ali Maredia <[email protected]>
@mergify mergify bot removed the ci-failure label Jan 18, 2025
Copy link
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobotSail RobotSail merged commit bdece44 into instructlab:main Jan 18, 2025
17 checks passed
@mergify mergify bot added the one-approval label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file one-approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants