Skip to content

Commit

Permalink
Merge pull request #196 from intel/ocrregresion
Browse files Browse the repository at this point in the history
fix regression in metrics command causing error on some AWS m5 and m6 instance types
  • Loading branch information
harp-intel authored Feb 5, 2025
2 parents c93632d + 4710232 commit 4188374
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/metrics/event_defs.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ func isCollectableEvent(event EventDefinition, metadata Metadata) bool {
}
// off-core response events
if event.Device == "cpu" && (strings.HasPrefix(event.Name, "OCR") || strings.HasPrefix(event.Name, "OFFCORE_REQUESTS_OUTSTANDING")) {
if !metadata.SupportsOCR {
if !(metadata.SupportsOCR && metadata.SupportsUncore) {
slog.Debug("Off-core response events not supported on target", slog.String("event", event.Name))
return false
} else if flagScope == scopeProcess || flagScope == scopeCgroup {
Expand Down

0 comments on commit 4188374

Please sign in to comment.