-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests_l2: Update qatlib workload to use its dnf package #163
Conversation
Signed-off-by: vbedida79 <[email protected]>
Nice optimization, the dockerfile is much more concise and readable with the dnf package instead of building from source. A win for developers, customers and community. |
@@ -113,7 +113,7 @@ $ oc logs intel-dgpu-hwinfo-l4572 | |||
``` | |||
|
|||
### Verify Intel® QuickAssist Technology provisioning | |||
This workload runs [qatlib](https://github.com/intel/qatlib) sample tests. Refer to the [qatlib readme](https://github.com/intel/qatlib/blob/main/INSTALL) for more details. | |||
This workload runs [qatlib](https://github.com/intel/qatlib) sample tests. Qatlib package is available in ```codeready-builder-for-rhel-8-x86_64-rpms``` and ```codeready-builder-for-rhel-9-x86_64-rpms``` repositories on RHEL8 and RHEL9 respectively. To enable this subscription required repository via buildconfig, please follow [link](https://docs.openshift.com/container-platform/4.13/cicd/builds/running-entitled-builds.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Qatlib RPM packages are available ...
Please put the subscripiton into the notes below. Please be adviced, I also revised the link. :-)
Notes: Builds that use Red Hat subscriptions to install content must include the entitlement keys as a build secret. To enable this subscription via buildconfig, please follow link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
entitlements builds did not work. will be submitting a commit by using subscription manager, which works. Will track as an enhancement issue for next releases
ARG BUILDER=registry.access.redhat.com/ubi9-minimal:latest | ||
FROM ${BUILDER} | ||
RUN microdnf -y update && \ | ||
microdnf install -y qatlib-tests qatlib-devel qatlib --enablerepo=codeready-builder-for-rhel-9-x86_64-rpms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't build applications with qatlib, I think qatlib-devel is not needed.
Submitted in PR #181 |
Signed-off-by: vbedida79 [email protected]