nfd: Update NFD CR's to support SGX EPC #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hershpa
approved these changes
Jun 7, 2024
uMartinXu
reviewed
Jun 7, 2024
Fix for issue intel#255 Signed-off-by: vbedida79 <[email protected]>
vbedida79
force-pushed
the
patch-070624-1
branch
from
a6c5bd1 to
af39d05
Compare
Created #255, added in commit log |
uMartinXu
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255
Removed SGX
extraLabelNsandresourceLabelsfrom NodeFeatureDiscovery CR. Added SGX EPC asin the NodeFeatureRule CR.
With these changes, initContainer in SGXDevicePlugin CR wont be used (in Intel device plugins 0.29.0)
Signed-off-by: vbedida79 [email protected]