[SYCL] Refactor sycl::vec's operators implementation #16557
Merged
+217
−217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't use `sycl::vec::vector_t`, as it is planned to be removed from the SYCL 2020 (KhronosGroup/SYCL-Docs#676). Note that this implementation is NOT required to use it, so this PR can be merged before the specification change. * Use `ext_vector_type`-based optimized implementation whenever it's available and not on device only. This is a recommit of intel#16529 with an additional `#if __clang_major__ >= 20` guard around `static_assert` on the expression that wasn't constant in clang-19.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
See https://godbolt.org/z/dPa9zKfGo for the reduced test case of the previous post-commit error. |
uditagarwal97
approved these changes
Jan 8, 2025
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sycl::vec::vector_t, as it is planned to be removed from the SYCL 2020 (Remove underspecified vector_t KhronosGroup/SYCL-Docs#676). Notethat this implementation is NOT required to use it, so this PR can be merged before the specification change.
ext_vector_type-based optimized implementation whenever it's available and not on device only.This is a recommit of #16529 with an additional
#if __clang_major__ >= 20guard aroundstatic_asserton the expression that wasn't constant in clang-19.