Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the usage of -flto and use -lto-emit-asm instead #16884

Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from

Conversation

omarahmed1111
Copy link
Contributor

@omarahmed1111 omarahmed1111 commented Feb 4, 2025

This reverts this PR and add another solution to that problem mentioned in this issue. This was the result of llvm upstream discussion here

@omarahmed1111
Copy link
Contributor Author

@mdtoguchi @AlexeySachkov The PR is failing in some tests due to not finding clang-nvlink-wrapper tool. I saw locally that the tool should be built by default with other clang tools and it works normally. Do you have an idea where the PATH is initialized on CI or how to debug that?

@AlexeySachkov
Copy link
Contributor

@mdtoguchi @AlexeySachkov The PR is failing in some tests due to not finding clang-nvlink-wrapper tool. I saw locally that the tool should be built by default with other clang tools and it works normally. Do you have an idea where the PATH is initialized on CI or how to debug that?

My guess is that dependency is missing here:

list(APPEND SYCL_E2E_TEST_DEPS
sycl-toolchain
FileCheck
not
)

clang-nvlink-wrapper is not a part of our sycl-toolchain - if it should be (i.e. that is not a test-only dependency), then the following CMakeLists.txt should be updated:

add_custom_target(sycl-compiler

Hope this helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants