Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable log package to distribute a stored logger to all other packages #117

Merged
merged 7 commits into from
Aug 5, 2024
Merged

Enable log package to distribute a stored logger to all other packages #117

merged 7 commits into from
Aug 5, 2024

Conversation

equals215
Copy link
Member

No description provided.

@equals215 equals215 linked an issue Aug 5, 2024 that may be closed by this pull request
SIGSEGV logging in BatchEnqueue #108
Closed
@equals215 equals215 self-assigned this Aug 5, 2024
@equals215 equals215 requested a review from CorentinB August 5, 2024 15:00
@equals215 equals215 added bug Something isn't working enhancement New feature or request P1 very high priority labels Aug 5, 2024
@equals215
feat: gave logger instances to Queue and IndexManager through log.Def…
cd8a275 
…aultOrStored() at queue/indexManager init time
@equals215 equals215 marked this pull request as ready for review August 5, 2024 15:09
CorentinB
CorentinB previously approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@CorentinB CorentinB left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (but test doesn't pass)

@equals215
Copy link
Member Author

Looks good to me (but test doesn't pass)

weird I might have broken smth, on it

@equals215
Copy link
Member Author

equals215 commented Aug 5, 2024 •
edited
Loading

found the error : once.Do() is called inside of a once.Do() when DefaultOrStored() is called and no logger exists already then hangs golang/go#53758

@equals215
Copy link
Member Author

tests wont pass due to #118, merging

@equals215 equals215 merged commit f447a27 into main Aug 5, 2024
1 check passed
@equals215 equals215 deleted the feat/distribute-logger-to-queue branch August 5, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CorentinB CorentinB CorentinB left review comments

Assignees

@equals215 equals215

Labels
bug Something isn't working enhancement New feature or request P1 very high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SIGSEGV logging in BatchEnqueue
2 participants
@equals215 @CorentinB