Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@internetarchive/[email protected] #1315

Merged
merged 1 commit into from
Feb 20, 2024
Merged

@internetarchive/[email protected] #1315

merged 1 commit into from
Feb 20, 2024

Conversation

iisa
Copy link
Contributor

@iisa iisa commented Feb 15, 2024

@cdrini cdrini closed this Feb 16, 2024
@cdrini cdrini reopened this Feb 16, 2024
@cdrini
Copy link
Contributor

cdrini commented Feb 16, 2024

That's weird ci got stuck! Closed/reopened, that seemed to give it a kick 👍

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (08b5289) 69.29% compared to head (530f26f) 69.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1315   +/-   ##
=======================================
  Coverage   69.29%   69.29%           
=======================================
  Files          59       59           
  Lines        5080     5080           
  Branches     1068     1068           
=======================================
  Hits         3520     3520           
  Misses       1533     1533           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Tested general usage and seems good.

@cdrini cdrini merged commit bd1c3fb into master Feb 20, 2024
12 checks passed
@cdrini cdrini deleted the item-nav-share-fix branch February 20, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants