Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove File and Review objects #20

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Remove File and Review objects #20

merged 4 commits into from
Jan 16, 2025

Conversation

jbuckner
Copy link
Contributor

@jbuckner jbuckner commented Jan 16, 2025

These are specific to the metadata-service response

Copy link

github-actions bot commented Jan 16, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-01-16 22:40 UTC

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 72.53%. Comparing base (806b10e) to head (ee7148b).

Files with missing lines Patch % Lines
src/models/metadata.ts 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   72.96%   72.53%   -0.43%     
==========================================
  Files          13       11       -2     
  Lines         858      710     -148     
  Branches       23       16       -7     
==========================================
- Hits          626      515     -111     
+ Misses        232      195      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

They're specific to the metadata-service response
@jbuckner jbuckner changed the title Add falsy checks to File and Review Remove File and Review objects Jan 16, 2025
@jbuckner jbuckner merged commit bc7bb9f into main Jan 16, 2025
2 checks passed
@jbuckner jbuckner deleted the more-falsy-checks branch January 16, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants