Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBDEV-7037 Add collection_layout metadata field #3

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

rebecca-shoptaw
Copy link
Contributor

Adds a collection_layout field to metadata, for use in the new custom collections.

@rebecca-shoptaw rebecca-shoptaw force-pushed the webdev6513-custom-collection-layout branch from d45bf36 to 7f9253c Compare October 3, 2024 19:07
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.81%. Comparing base (52502aa) to head (c37b9e2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/models/metadata.ts 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   71.01%   70.81%   -0.20%     
==========================================
  Files          17       17              
  Lines        1128     1134       +6     
  Branches       19       19              
==========================================
+ Hits          801      803       +2     
- Misses        325      329       +4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@latonv latonv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just noting version change.

package.json Outdated Show resolved Hide resolved
@rebecca-shoptaw rebecca-shoptaw force-pushed the webdev6513-custom-collection-layout branch from 7f9253c to c37b9e2 Compare October 3, 2024 20:03
@rebecca-shoptaw rebecca-shoptaw merged commit 9172d47 into main Oct 3, 2024
1 check passed
@rebecca-shoptaw rebecca-shoptaw deleted the webdev6513-custom-collection-layout branch October 3, 2024 20:05
@rebecca-shoptaw rebecca-shoptaw mentioned this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants