New package: mobile-top-nav #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good! 💪 |
ok sounds good. we will forge forth |
|
@koderjoker would you be able to help make the demo file &/or stories work inside the new directory? I moved most of the files into the new folder. I left a few just for reference. |
|
@koderjoker this is the final piece for directory migration. Please do take a look at this, and try it out. If you see any issue with regards to directory structure - includig any component behavioral issues, please feel free to create commits. If good to go, do merge to master. Let's get this in as soon as we can. I will be working on new tasks off of this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving top nav to new location.
#312 - please see acceptance notes in main issue.
Technical
This component will now be ready to be a stand-alone package.
Testing
Pull branch > run
npm installTo run Storybook: run
npm run storybookTo run Demo app (openwc): run
npm run start