-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use versions from firebase_core pubspec #351
Open
frederikstonge
wants to merge
2
commits into
invertase:main
Choose a base branch
from
frederikstonge:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Needs Attention
OP created or responded to issue and it needs attention.
label
Jan 6, 2025
russellwheatley
had a problem deploying
to
CI Environment
January 15, 2025 11:04 — with
GitHub Actions
Failure
russellwheatley
had a problem deploying
to
CI Environment
January 15, 2025 11:04 — with
GitHub Actions
Failure
russellwheatley
had a problem deploying
to
CI Environment
January 15, 2025 11:04 — with
GitHub Actions
Failure
This LGTM. CI fails because it is a fork. I ran tests locally and it was successful:
The most important test is this one: https://github.com/invertase/flutterfire_cli/blob/main/packages/flutterfire_cli/test/configure_test.dart#L1417-L1421 Which checks versions are ported over correctly. |
Wait until FlutterFire's next release before we merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are TODO above gradle plugin versions of google services, crashlytics and performance to get them from the firebase_core pubspec definition.
❌❌ We might need to wait for this to be merged to avoid breaking changes : firebase/flutterfire#16944 ❌❌
Type of Change
feat
-- New feature (non-breaking change which adds functionality)fix
-- Bug fix (non-breaking change which fixes an issue)!
-- Breaking change (fix or feature that would cause existing functionality to change)refactor
-- Code refactorci
-- Build configuration changedocs
-- Documentationchore
-- Chore