Skip to content

Commit

Permalink
remove forgotten useless code + final code review
Browse files Browse the repository at this point in the history
  • Loading branch information
dprevost-LMI committed Nov 1, 2024
1 parent c5cc680 commit 6e86b52
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 17 deletions.
7 changes: 5 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,11 @@ Ensure you have TypeScript compiler running to listen to `react-native` submodul
yarn build:rn:watch
```

## Step 5
## Testing Code

### Manual testing

To run the example app and do manual testing. Make sure step 3 above is done first!

Run on iOS. Change `--simulator 'iPhone 16'` for you simulator if needed.
```bash
Expand All @@ -56,7 +60,6 @@ or Android
yarn run:android
```

## Testing Code

### Unit Testing

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,13 @@
*
*/

import static app.notifee.core.event.NotificationEvent.TYPE_ACTION_PRESS;

import android.app.PendingIntent;
import android.content.Context;
import android.content.Intent;
import android.os.Bundle;
import app.notifee.core.event.MainComponentEvent;
import app.notifee.core.model.NotificationAndroidPressActionModel;
import app.notifee.core.model.NotificationModel;
import app.notifee.core.utility.IntentUtils;

import java.util.UUID;

public class NotificationPendingIntent {
Expand Down Expand Up @@ -192,15 +188,4 @@ static Intent createLaunchActivityIntent(

return null;
}

public static PendingIntent createPendingIntent(Bundle hangUpActionBundle, int notificationModel, NotificationModel notificationModel1) {
Bundle pressActionBundle = hangUpActionBundle.getBundle("pressAction");
return NotificationPendingIntent.createIntent(
notificationModel,
pressActionBundle,
TYPE_ACTION_PRESS,
new String[]{"notification", "pressAction"},
notificationModel1.toBundle(),
pressActionBundle);
}
}

0 comments on commit 6e86b52

Please sign in to comment.