Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(input): add missing imports for maskito in React #3976

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Dec 27, 2024

Current Behavior

The input mask demo is not working in StackBlitz for React. Additionally, it incorrectly passes dependencies as files.

  1. Navigate to Input Masking.
  2. Select React and then Open in StackBlitz.
  3. Observe that a folder named @maskito is present, containing two files (core and react) which only contain dependency versions.
  4. Note that the demo does not display correctly, resulting in a white screen where the demo should appear.

New Behavior

The dependencies are no longer passed as files, and the missing imports are added, allowing the React demo to function correctly.

  1. Navigate to Input Masking.
  2. Select React and then Open in StackBlitz.
  3. Confirm that the @maskito folder is no longer there and the demo displays as expected.

Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 10:06pm

@brandyscarney brandyscarney marked this pull request as ready for review December 27, 2024 22:10
@brandyscarney brandyscarney requested a review from a team as a code owner December 27, 2024 22:10
@brandyscarney brandyscarney merged commit 709ca9f into main Dec 31, 2024
4 checks passed
@brandyscarney brandyscarney deleted the docs-react-stackblitz-input-mask branch December 31, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants