Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #20 add default export to buffer-es6.js module #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

habdelra
Copy link

@habdelra habdelra commented Feb 2, 2021

fixes #20 add default export to buffer-es6.js module

@remorses
Copy link

Can this be merged please?

@lemoustachiste
Copy link

I am experiencing this issue but I am not sure of the side effects of this change.
It would be all in all a breaking change and it's not highlighted as such in the commit.
I think the better fix would be at the moment of injecting the code into the build, replacing import buffer from 'buffer' by import * as buffer from 'buffer'.

I am not a maintainer of this library so this is just my 2 cents trying to deal with this issue.

@ralyodio
Copy link

I'm needing this. For some reason I get an error when trying to do:

buffer: 'rollup-plugin-node-polyfills/polyfills/buffer-es6', as an alias in vite/sveltekit.

@ralyodio
Copy link

Can someone merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants