Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iota-move): fix os error 2 for iota move new command using <NAME> with uppercase letter(s) #4916

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

roman1e2f5p8s
Copy link
Contributor

Description of change

  • Use the provided <NAME> instead of its lowercase variant to obtain the correct and existing path for writing.
  • Update <NAME> validation error message: since <NAME> is validated as an Identifier, a valid <NAME> can also start with an uppercase letter or underscore.

Links to any relevant issues

Fixes #4895.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Run the following before and after the change:

cargo build
./target/debug/iota move new Xxx

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@roman1e2f5p8s roman1e2f5p8s added sc-platform Issues related to the Smart Contract Platform group. dev-tools Issues related to the Developer Tools Team core-protocol labels Jan 20, 2025
@roman1e2f5p8s roman1e2f5p8s self-assigned this Jan 20, 2025
@roman1e2f5p8s roman1e2f5p8s requested review from a team as code owners January 20, 2025 10:17
Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rebased-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 10:17am
wallet-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 10:17am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Jan 20, 2025 10:17am
apps-ui-kit ⬜️ Ignored (Inspect) Jan 20, 2025 10:17am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-protocol dev-tools Issues related to the Developer Tools Team research sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug (iota-move)]: iota move new fails if using only the required argument <NAME> with uppercase letter(s)
2 participants