Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove whizzzkid as member and add ipjs maintainer to test-ipfs… #36

Merged
merged 6 commits into from
May 6, 2024

Conversation

SgtPooki
Copy link
Contributor

…-example

Summary

Why do you need this?

  1. javascript devs are maintainers of test-ipfs-example (and also all helia-* repos...)
  2. whizzzkid is no longer active here

What else do we need to know?

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@SgtPooki SgtPooki requested review from a team as code owners April 18, 2024 23:42
Copy link
Contributor

github-actions bot commented Apr 18, 2024

The following access changes will be introduced as a result of applying the plan:

Access Changes
User achingbrain:
  - will gain maintain permission to test-ipfs-example
User sgtpooki:
  - will gain maintain permission to test-ipfs-example
User whizzzkid:
  - will lose admin permission to helia
  - will lose maintain permission to helia-examples

github/ipfs-examples.yml Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented May 6, 2024

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

ipfs-examples

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # github_repository_collaborator.this["helia:whizzzkid"] will be destroyed
  # (because key ["helia:whizzzkid"] is not in for_each map)
  - resource "github_repository_collaborator" "this" {
      - id         = "helia:whizzzkid" -> null
      - permission = "admin" -> null
      - repository = "helia" -> null
      - username   = "whizzzkid" -> null
    }

  # github_team_membership.this["alumni:whizzzkid"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "7328036"
      + username = "whizzzkid"
    }

  # github_team_membership.this["ipjs:whizzzkid"] will be destroyed
  # (because key ["ipjs:whizzzkid"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"ac5da8e2604559fcf5090f8fda73510a0efa20dae1387ca2c6d0d91a78124989\"" -> null
      - id       = "7566362:whizzzkid" -> null
      - role     = "member" -> null
      - team_id  = "7566362" -> null
      - username = "whizzzkid" -> null
    }

  # github_team_repository.this["ipjs:test-ipfs-example"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "maintain"
      + repository = "test-ipfs-example"
      + team_id    = "7566362"
    }

Plan: 2 to add, 0 to change, 2 to destroy.

@galargh galargh merged commit 235e583 into ipfs-examples:master May 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants