Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make compatible with ipld-prime linksystem changes #14

Merged
merged 4 commits into from
Mar 15, 2021
Merged

Conversation

acruikshank
Copy link
Contributor

Motivation

The linksystem modifications to go-ipld-prime changes cidlink.MulticodecDecoder to ipld.Decoder and similar changes. This PR links to the linksystem branch and makes the necessary changes to prepare for linksystem landing in master and to facilitate linksystem preparations in downstream repos.

This PR will remain a draft until linksystem lands and the dependency is changed.

@willscott
Copy link
Member

this will need to update to make use of whatever registry falls out of multiformats/go-multihash#136

@acruikshank acruikshank marked this pull request as ready for review March 15, 2021 18:13
@acruikshank acruikshank requested a review from warpfork March 15, 2021 18:13
A similar change to Encode and Decode function names came in
go-ipld-prime v0.9.0, so this keeps this library in sync.

Improved package docs a bit to talk about the new go-ipld-prime
LinkSystem, which is a bit clearer to refer to than before.

Target-of-opportunity fix some typos in docs.
Copy link
Contributor

@warpfork warpfork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I tossed another commit on top too, which does a few function name changes and docs tweaks, so check me in return I didn't introduce any badness there.

@acruikshank acruikshank merged commit 748624f into master Mar 15, 2021
@mvdan mvdan deleted the linksystem branch April 20, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants