make debugger class configurable #1307
Conversation
| @@ -110,11 +113,9 @@ def __init__(self, **kwargs): | |||
|
|
|||
| self.executing_blocking_code_in_main_shell = False | |||
|
|
|||
| from .debugger import Debugger, _is_debugpy_available | |||
There was a problem hiding this comment.
It looks like #1223 intentionally introduced this lazy import. Let's make sure we're addressing the need there as well before making this an eager import at the top of the file.
There was a problem hiding this comment.
In particular, does this change mean that python -m ipykernel install --sys-prefix has spurious warnings?
There was a problem hiding this comment.
CC @krassowski who made this lazy import change earlier this year.
There was a problem hiding this comment.
Thanks for spotting, yes this is intentional to address #1198
ipykernel/ipkernel.py
Outdated
| @@ -71,6 +72,8 @@ class IPythonKernel(KernelBase): | |||
| shell = Instance("IPython.core.interactiveshell.InteractiveShellABC", allow_none=True) | |||
| shell_class = Type(ZMQInteractiveShell) | |||
|
|
|||
| debugger_class = Type(Debugger) | |||
There was a problem hiding this comment.
You can also give this class as a full-specified dotted string (like in the shell instance above), so we could move the import above back to being an on-demand import in the class definition.
There was a problem hiding this comment.
I think this should work:
| debugger_class = Type(Debugger) | |
| debugger_class = Type("ipykernel.debugger.Debugger") |
There was a problem hiding this comment.
Thanks for the suggestion; I think if I do this I can omit the import altogether?
EDIT: for Debugger, but not for _is_debugpy_available I guess
There was a problem hiding this comment.
It seems fine, but not 100% sure as I get an error when trying to install kernel: #1309
In this PR, add fields
compiler_classanddebugger_classdefaulting to the normal types. Kernel subclasses can override these to provide additional customizations.