Adding simplified HAL dispatch methods. #18189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvanik
added
compiler/dialects
benvanik
force-pushed
the
users/benvanik/dispatch2
branch
14 times, most recently
from
973eefd to
d1d77f9
Compare
These combine push constants and push descriptor sets into the dispatch calls as in practice we have a near 1:1 relationship anyway. Pipeline layouts are still used in HAL interfaces to allow the compiler to map the information but are otherwise not used by the new ops. The `--iree-hal-experimental-dispatch2` flag enables emitting the new ops though no targets currently implement them. Since executables no longer require pipeline layouts in this simplified model the `--iree-hal-experimental-executable-create2` flag can be used to stop passing them. Progress on #18154. Signed-off-by: Ben Vanik <[email protected]>
benvanik
force-pushed
the
users/benvanik/dispatch2
branch
from
d1d77f9 to
59bf417
Compare
ScottTodd
reviewed
Aug 12, 2024
benvanik
requested review from
antiagainst,
nithinsubbiah,
MaheshRavishankar and
stellaraccident
as code owners
ScottTodd
approved these changes
Aug 12, 2024
rohan-tan-bhowmik
pushed a commit
to rohan-tan-bhowmik/iree
that referenced
this pull request
Sep 4, 2024
These combine push constants and push descriptor sets into the dispatch calls as in practice we have a near 1:1 relationship anyway. Pipeline layouts are still used in HAL interfaces to allow the compiler to map the information but are otherwise not used by the new ops. The `--iree-hal-experimental-dispatch2` flag enables emitting the new ops. Since executables no longer require pipeline layouts in this simplified model the `--iree-hal-experimental-executable-create2` flag can be used to stop passing them; targets that support dispatch2 will ignore them if provided. Future changes will start to add support on targets for the simplified bindings and then remove the existing pipeline layout-based binding model as a breaking ABI change. Current target status: * [x] Local/CPU: executable-create2 and executable-dispatch2 supported (backward compat) * [x] CUDA: executable-dispatch2 supported (backward compat) * [x] HIP: executable-dispatch2 supported (backward compat) * [x] Metal: executable-dispatch2 supported (backward compat) * [x] Vulkan: executable-dispatch2 supported (backward compat) * [x] WebGPU: executable-dispatch2 supported (backward compat) Reworking the CUDA/HIP/Metal/Vulkan/WebGPU flatbuffers to support executable-create2 will be done in a follow-up. Progress on iree-org#18154.
rohan-tan-bhowmik
pushed a commit
to rohan-tan-bhowmik/iree
that referenced
this pull request
Sep 4, 2024
These combine push constants and push descriptor sets into the dispatch calls as in practice we have a near 1:1 relationship anyway. Pipeline layouts are still used in HAL interfaces to allow the compiler to map the information but are otherwise not used by the new ops. The `--iree-hal-experimental-dispatch2` flag enables emitting the new ops. Since executables no longer require pipeline layouts in this simplified model the `--iree-hal-experimental-executable-create2` flag can be used to stop passing them; targets that support dispatch2 will ignore them if provided. Future changes will start to add support on targets for the simplified bindings and then remove the existing pipeline layout-based binding model as a breaking ABI change. Current target status: * [x] Local/CPU: executable-create2 and executable-dispatch2 supported (backward compat) * [x] CUDA: executable-dispatch2 supported (backward compat) * [x] HIP: executable-dispatch2 supported (backward compat) * [x] Metal: executable-dispatch2 supported (backward compat) * [x] Vulkan: executable-dispatch2 supported (backward compat) * [x] WebGPU: executable-dispatch2 supported (backward compat) Reworking the CUDA/HIP/Metal/Vulkan/WebGPU flatbuffers to support executable-create2 will be done in a follow-up. Progress on iree-org#18154.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These combine push constants and push descriptor sets into the dispatch calls as in practice we have a near 1:1 relationship anyway. Pipeline layouts are still used in HAL interfaces to allow the compiler to map the information but are otherwise not used by the new ops.
The
--iree-hal-experimental-dispatch2flag enables emitting the new ops. Since executables no longer require pipeline layouts in this simplified model the--iree-hal-experimental-executable-create2flag can be used to stop passing them; targets that support dispatch2 will ignore them if provided. Future changes will start to add support on targets for the simplified bindings and then remove the existing pipeline layout-based binding model as a breaking ABI change.Current target status:
Reworking the CUDA/HIP/Metal/Vulkan/WebGPU flatbuffers to support executable-create2 will be done in a follow-up.
Progress on #18154.