Reland "[DispatchCreation] Run preprocessing before..." #18939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanWood1
force-pushed
the
revert-18934-revert-18920-run_preprocessing_before_elem_fusion
branch
4 times, most recently
from
459313b to
a301118
Compare
Signed-off-by: Ian Wood <[email protected]>
|
@MaheshRavishankar or @hanhanW can I get a review on this please? |
MaheshRavishankar
approved these changes
Nov 18, 2024
|
Thank you! |
IanWood1
deleted the
revert-18934-revert-18920-run_preprocessing_before_elem_fusion
branch
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
Land iree-org#18934 after fixing mi250 regressions. Instead of moving the whole pass (which "interchanges" the indexing maps and was the root of the regressions), only move the single pattern `GatherFusionPattern` into `ElementwiseOpFusion.cpp`. closes: iree-org#19077 Signed-off-by: Ian Wood <[email protected]>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
Land iree-org#18934 after fixing mi250 regressions. Instead of moving the whole pass (which "interchanges" the indexing maps and was the root of the regressions), only move the single pattern `GatherFusionPattern` into `ElementwiseOpFusion.cpp`. closes: iree-org#19077 Signed-off-by: Ian Wood <[email protected]> Signed-off-by: Giacomo Serafini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Land #18934 after fixing mi250 regressions. Instead of moving the whole pass (which "interchanges" the indexing maps and was the root of the regressions), only move the single pattern
GatherFusionPatternintoElementwiseOpFusion.cpp.closes: #19077