Mark failing Colab notebook tests as XFAIL. #19031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
added
infrastructure
marbre
approved these changes
Nov 5, 2024
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
See iree-org#18919. Tested here: https://github.com/iree-org/iree/actions/runs/11689771962 * I was able to reproduce the `tensorflow_hub_import.ipynb` compile failure in Colab. Might be a real compiler regression in there. * I was _not_ able to reproduce the `tflite_text_classification.ipynb` error - likely some diff between the simulated test environment we have and what is running in hosted Colab instances.
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
See iree-org#18919. Tested here: https://github.com/iree-org/iree/actions/runs/11689771962 * I was able to reproduce the `tensorflow_hub_import.ipynb` compile failure in Colab. Might be a real compiler regression in there. * I was _not_ able to reproduce the `tflite_text_classification.ipynb` error - likely some diff between the simulated test environment we have and what is running in hosted Colab instances. Signed-off-by: Giacomo Serafini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #18919.
Tested here: https://github.com/iree-org/iree/actions/runs/11689771962
tensorflow_hub_import.ipynbcompile failure in Colab. Might be a real compiler regression in there.tflite_text_classification.ipynberror - likely some diff between the simulated test environment we have and what is running in hosted Colab instances.