e2e matmul tests: support f64 #19093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjacob
force-pushed
the
users/bjacob/f64
branch
2 times, most recently
from
f82286b to
6abd887
Compare
Signed-off-by: Benoit Jacob <[email protected]>
bjacob
force-pushed
the
users/bjacob/f64
branch
from
6abd887 to
aa3eabe
Compare
|
@benvanik , @ScottTodd , please review this: this sits at the bottom of a long chain of PRs. |
benvanik
approved these changes
Nov 12, 2024
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
This adds some e2e matmul tests on CPU for f64 (double precision). Motivation: - This is technically supported by IREE. - This was already > 50% implemented in the e2e matmul testing framework, and the partly implemented status was not a good steady state to be in. - My real motivation is iree-org#19099, I'm doing a round of AMD MFMA / data tiling improvements, thought we should support a denser set of MFMA intrinsics, noticed this has been supported since CDNA2 so we shouldn't be prevented from supporting it just because our e2e matmul tests can't cover it. Signed-off-by: Benoit Jacob <[email protected]>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
This adds some e2e matmul tests on CPU for f64 (double precision). Motivation: - This is technically supported by IREE. - This was already > 50% implemented in the e2e matmul testing framework, and the partly implemented status was not a good steady state to be in. - My real motivation is iree-org#19099, I'm doing a round of AMD MFMA / data tiling improvements, thought we should support a denser set of MFMA intrinsics, noticed this has been supported since CDNA2 so we shouldn't be prevented from supporting it just because our e2e matmul tests can't cover it. Signed-off-by: Benoit Jacob <[email protected]> Signed-off-by: Giacomo Serafini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some e2e matmul tests on CPU for f64 (double precision). Motivation: