-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python][tuner] Add bindings for MMAIntrinsic #19095
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Kuderski <[email protected]>
3f88d20
to
e3347ca
Compare
I chatted with @makslevental and I want to stop mirroring enums on the CAPI side and instead pass around opaque |
Signed-off-by: Jakub Kuderski <[email protected]>
Signed-off-by: Jakub Kuderski <[email protected]>
Signed-off-by: Jakub Kuderski <[email protected]>
makslevental
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Jakub Kuderski <[email protected]>
12 tasks
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
Expose MMA intrinsics to python. This includes both the `MMAIntrinsic` attribute and the enum values. In addition, expose element/vector types and shapes from the MMA interface (but not the interface itself). This is so that the tuner can use the compiler as the SoT for all the intrinsics and use them to parse target properties and generate constraints. The enum values are kept opaque so that we do not have to duplicate the definitions in TD and C API headers.
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
Expose MMA intrinsics to python. This includes both the `MMAIntrinsic` attribute and the enum values. In addition, expose element/vector types and shapes from the MMA interface (but not the interface itself). This is so that the tuner can use the compiler as the SoT for all the intrinsics and use them to parse target properties and generate constraints. The enum values are kept opaque so that we do not have to duplicate the definitions in TD and C API headers. Signed-off-by: Giacomo Serafini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose MMA intrinsics to python. This includes both the
MMAIntrinsic
attribute and the enum values. In addition, expose element/vector types and shapes from the MMA interface (but not the interface itself).This is so that the tuner can use the compiler as the SoT for all the intrinsics and use them to parse target properties and generate constraints.
The enum values are kept opaque so that we do not have to duplicate the definitions in TD and C API headers.