Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python][tuner] Add bindings for MMAIntrinsic #19095

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

kuhar
Copy link
Member

@kuhar kuhar commented Nov 10, 2024

Expose MMA intrinsics to python. This includes both the MMAIntrinsic attribute and the enum values. In addition, expose element/vector types and shapes from the MMA interface (but not the interface itself).

This is so that the tuner can use the compiler as the SoT for all the intrinsics and use them to parse target properties and generate constraints.

The enum values are kept opaque so that we do not have to duplicate the definitions in TD and C API headers.

@kuhar kuhar force-pushed the mma-intrinsic-bindings branch from 3f88d20 to e3347ca Compare November 11, 2024 15:50
@kuhar
Copy link
Member Author

kuhar commented Nov 11, 2024

I chatted with @makslevental and I want to stop mirroring enums on the CAPI side and instead pass around opaque uint32_t. I'm going to convert this to a draft for the time being.

@kuhar kuhar marked this pull request as draft November 11, 2024 17:17
Signed-off-by: Jakub Kuderski <[email protected]>
@kuhar kuhar marked this pull request as ready for review November 11, 2024 19:24
Signed-off-by: Jakub Kuderski <[email protected]>
Signed-off-by: Jakub Kuderski <[email protected]>
Copy link
Contributor

@makslevental makslevental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Jakub Kuderski <[email protected]>
@kuhar kuhar enabled auto-merge (squash) November 11, 2024 20:00
@kuhar kuhar merged commit 48f6dee into iree-org:main Nov 11, 2024
36 checks passed
Groverkss pushed a commit to Groverkss/iree that referenced this pull request Dec 1, 2024
Expose MMA intrinsics to python. This includes both the `MMAIntrinsic`
attribute and the enum values. In addition, expose element/vector types
and shapes from the MMA interface (but not the interface itself).

This is so that the tuner can use the compiler as the SoT for all the
intrinsics and use them to parse target properties and generate
constraints.

The enum values are kept opaque so that we do not have to duplicate the
definitions in TD and C API headers.
giacs-epic pushed a commit to giacs-epic/iree that referenced this pull request Dec 4, 2024
Expose MMA intrinsics to python. This includes both the `MMAIntrinsic`
attribute and the enum values. In addition, expose element/vector types
and shapes from the MMA interface (but not the interface itself).

This is so that the tuner can use the compiler as the SoT for all the
intrinsics and use them to parse target properties and generate
constraints.

The enum values are kept opaque so that we do not have to duplicate the
definitions in TD and C API headers.

Signed-off-by: Giacomo Serafini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants