Refactor existing MMA intrinsics #19098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjacob
force-pushed
the
users/bjacob/refactor-mma-intrinsics
branch
from
638d50f to
a44474a
Compare
kuhar
approved these changes
Nov 11, 2024
Signed-off-by: Benoit Jacob <[email protected]>
Signed-off-by: Benoit Jacob <[email protected]>
bjacob
force-pushed
the
users/bjacob/f64
branch
from
6abd887 to
aa3eabe
Compare
bjacob
force-pushed
the
users/bjacob/refactor-mma-intrinsics
branch
from
a44474a to
17dc529
Compare
raikonenfnu
approved these changes
Nov 12, 2024
raikonenfnu
added a commit
to raikonenfnu/iree
that referenced
this pull request
Nov 14, 2024
Apply similar cleanups to what is done in iree-org#19098. For most part we do: 1. Templateize getVectorType and getOpaqueMmaLayout to work on any intrinsic 2. Use common getOpaqueMmaLayout for VirtualMMA 3. Update getABCElementTypes to be similar to MMAAttr Signed-off-by: Stanley Winata <[email protected]>
raikonenfnu
added a commit
to raikonenfnu/iree
that referenced
this pull request
Nov 14, 2024
Apply similar cleanups to what is done in iree-org#19098. For most part we do: 1. Templateize getVectorType and getOpaqueMmaLayout to work on any intrinsic 2. Use common getOpaqueMmaLayout for VirtualMMA 3. Update getABCElementTypes to be similar to MMAAttr 4. Rename get*MFMA fn to get*MMA since MFMA is CDNA specific but in reality it does not have to be MFMA instructions Signed-off-by: Stanley Winata <[email protected]> Signed-off-by: Stanley Winata <[email protected]>
bjacob
pushed a commit
that referenced
this pull request
Nov 14, 2024
…MAAttr (#19144) Apply similar cleanups to what is done in #19098. For most part we do: 1. Templateize getVectorType and getOpaqueMmaLayout to work on any intrinsic 2. Use common getOpaqueMmaLayout for VirtualMMA 3. Update getABCElementTypes to be similar to MMAAttr 4. Rename get.*MFMA fn to get.*MMA since MFMA is CDNA specific but in reality it does not have to be MFMA instructions Signed-off-by: Stanley Winata <[email protected]>
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
Some code simplifications in `IREEGPUAttrs.cpp`, and some shuffling of the MMAIntrinsic enum, making it easier to add more MMAIntrinsics in the future (see iree-org#19099). --------- Signed-off-by: Benoit Jacob <[email protected]>
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
…MAAttr (iree-org#19144) Apply similar cleanups to what is done in iree-org#19098. For most part we do: 1. Templateize getVectorType and getOpaqueMmaLayout to work on any intrinsic 2. Use common getOpaqueMmaLayout for VirtualMMA 3. Update getABCElementTypes to be similar to MMAAttr 4. Rename get.*MFMA fn to get.*MMA since MFMA is CDNA specific but in reality it does not have to be MFMA instructions Signed-off-by: Stanley Winata <[email protected]>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
Some code simplifications in `IREEGPUAttrs.cpp`, and some shuffling of the MMAIntrinsic enum, making it easier to add more MMAIntrinsics in the future (see iree-org#19099). --------- Signed-off-by: Benoit Jacob <[email protected]> Signed-off-by: Giacomo Serafini <[email protected]>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
…MAAttr (iree-org#19144) Apply similar cleanups to what is done in iree-org#19098. For most part we do: 1. Templateize getVectorType and getOpaqueMmaLayout to work on any intrinsic 2. Use common getOpaqueMmaLayout for VirtualMMA 3. Update getABCElementTypes to be similar to MMAAttr 4. Rename get.*MFMA fn to get.*MMA since MFMA is CDNA specific but in reality it does not have to be MFMA instructions Signed-off-by: Stanley Winata <[email protected]> Signed-off-by: Giacomo Serafini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code simplifications in
IREEGPUAttrs.cpp, and some shuffling of the MMAIntrinsic enum, making it easier to add more MMAIntrinsics in the future (see #19099).