[hip] Set the current device before calls into Hip. #19103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWoloszyn
requested review from
antiagainst and
nithinsubbiah
as code owners
benvanik
approved these changes
Nov 11, 2024
benvanik
approved these changes
Nov 11, 2024
AWoloszyn
force-pushed
the
hip-ctx
branch
2 times, most recently
from
50276f7 to
b47bf2f
Compare
This was referenced Nov 12, 2024
AWoloszyn
force-pushed
the
hip-ctx
branch
2 times, most recently
from
e5f15e4 to
4ef8dc1
Compare
This is a bit of a brute-force way to solve our main hip multi-device problems temporarily until the more complete fix is in place. Signed-off-by: Andrew Woloszyn <[email protected]>
Signed-off-by: Andrew Woloszyn <[email protected]>
Signed-off-by: Andrew Woloszyn <[email protected]>
Signed-off-by: Andrew Woloszyn <[email protected]>
Signed-off-by: Andrew Woloszyn <[email protected]>
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
This is a bit of a brute-force way to solve our main hip multi-device problems temporarily until the more complete fix is in place. For the single-device case this has negligible performance implications as `hipCtxSetCurrent` is a no-op in that case. For the multi-device case this could cause more significant performance problems if the user program swaps between devices within a thread. --------- Signed-off-by: Andrew Woloszyn <[email protected]>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
This is a bit of a brute-force way to solve our main hip multi-device problems temporarily until the more complete fix is in place. For the single-device case this has negligible performance implications as `hipCtxSetCurrent` is a no-op in that case. For the multi-device case this could cause more significant performance problems if the user program swaps between devices within a thread. --------- Signed-off-by: Andrew Woloszyn <[email protected]> Signed-off-by: Giacomo Serafini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a brute-force way to solve our main hip multi-device problems temporarily until
the more complete fix is in place.
For the single-device case this has negligible performance implications as
hipCtxSetCurrentisa no-op in that case.
For the multi-device case this could cause more significant performance problems if the user program
swaps between devices within a thread.