[LLVMGPU] Disable scf.forall distribution for matmulSimt #19302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are moving towards tile&fuse pipeline. `matmulSimt` pipeline is to be deprecated. Meanwhile, all existing tests that depend on matmulsimt pipeline shouldn't break and hence disabling the forall distribution for the pipeline.
pashu123
requested review from
MaheshRavishankar,
qedawkins,
kuhar and
Groverkss
as code owners
qedawkins
approved these changes
Nov 26, 2024
|
@pashu123 seems like there may be issues with SDXL perf after merging this PR |
|
cc: @qedawkins for visibility :^ |
|
That's surprising because this is just reverting to the behavior we've had for a long time, are we sure it's this PR? |
|
It started failing just after merging this one, but I can't say for sure because I haven't tried reproducing this locally |
|
@kuhar It might be because of 2602a2a (this is just reverting to the old behaviour) that @qedawkins mentioned. |
|
I see a similar huge regression right before this PR too: https://github.com/iree-org/iree/actions/runs/12023092109/job/33516722915 maybe an unstable runner? |
|
cc: @saienduri |
|
It started here: 77ff99c |
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
) We are moving towards tile&fuse pipeline. `matmulSimt` pipeline is to be deprecated. Meanwhile, all existing tests that depend on matmulsimt pipeline shouldn't break and hence disabling the forall distribution for the pipeline. Signed-off-by: Giacomo Serafini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are moving towards tile&fuse pipeline.
matmulSimtpipeline is to be deprecated. Meanwhile, all existing tests that depend on matmulsimt pipeline shouldn't break and hence disabling the forall distribution for the pipeline.