Trigger presubmit ci workflows from ci.yml
via workflow_call
.
#19445
+65
−114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History
These workflow jobs were originally part of
ci.yml
but they were moved out of part of #17957.Reasons to keep them separate
Reasons to merge them back
Less code duplication, particularly for
setup
andsummary
steps (see Share workflow failure alerting between ci.yml and pkgci.yml. #19444)Less noise in the checks view in pull requests (note all the
setup
jobs, and the PR above will add similarly dupliatedsummary
jobs):Centralized logs for checks, not split between multiple pages like they are currently:
This gives us a single
ci_summary
check inci.yml
to set as a required check instead of multiple split across workflowsGiven enough runner capacity / budget, we could run all these jobs on presubmit/postsubmit and not just on nightly schedules