Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger presubmit ci workflows from ci.yml via workflow_call. #19445

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

ScottTodd
Copy link
Member

@ScottTodd ScottTodd commented Dec 10, 2024

History

These workflow jobs were originally part of ci.yml but they were moved out of part of #17957.

Reasons to keep them separate

Reasons to merge them back

  • Less code duplication, particularly for setup and summary steps (see Share workflow failure alerting between ci.yml and pkgci.yml. #19444)

  • Less noise in the checks view in pull requests (note all the setup jobs, and the PR above will add similarly dupliated summary jobs): image

  • Centralized logs for checks, not split between multiple pages like they are currently:

    Current With this PR
    image image
  • This gives us a single ci_summary check in ci.yml to set as a required check instead of multiple split across workflows

  • Given enough runner capacity / budget, we could run all these jobs on presubmit/postsubmit and not just on nightly schedules

@ScottTodd ScottTodd added the infrastructure Relating to build systems, CI, or testing label Dec 10, 2024
ScottTodd added a commit that referenced this pull request Dec 11, 2024
Progress on #9305.

See also #19445, which triggers the
presubmit workflows (`linux_x64_bazel`, `linux_x64_clang`,
`linux_x64_clang_asan`) from `ci.yml`, removing the need to add alerting
code to those files. If that PR lands, the changes in those workflows
can be merged with these other changes.
@ScottTodd
Copy link
Member Author

I'm on the fence with this. I think it improves the experience on pull requests but it makes monitoring more complicated. I think with custom queries we can look up job statistics within workflow runs to build our own metrics though.

Thoughts, @iamakanshab @Eliasj42 @amd-chrissosa @marbre ?

@ScottTodd ScottTodd marked this pull request as ready for review December 18, 2024 16:11
Copy link
Member

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is reasonable to move this back to invoke from ci.yml and have the impression that at least the manual monitoring via the GH UI doesn't get worse. However, I don't know about more automated monitoring.

@ScottTodd ScottTodd merged commit 5c4bc67 into iree-org:main Dec 19, 2024
36 checks passed
@ScottTodd ScottTodd deleted the ci-fold-back branch December 19, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Relating to build systems, CI, or testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants