Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icvn domain #17824

Merged
merged 11 commits into from
Jan 1, 2025
Merged

Add icvn domain #17824

merged 11 commits into from
Jan 1, 2025
+12 −0

Conversation

HaiYTB
Copy link
Contributor

@HaiYTB HaiYTB commented Dec 23, 2024 •
edited
Loading

Requirements

Unless explicitly specified otherwise by a maintainer or in the requirement description, your domain must pass ALL the indicated requirements above.

Please note that we reserve the rights not to accept any domain at our own discretion.

  • The file is in the domains folder and is in the JSON format.
  • The file's name is all lowercased and alphanumeric.
  • You have completed your website.
  • The website is reachable.
  • The CNAME record doesn't contain https:// or /.
  • There is sufficient information at the owner field.

Website Link/Preview

@HaiYTB HaiYTB requested a review from a team as a code owner December 23, 2024 12:20
DEV-DIBSTER
DEV-DIBSTER requested changes Dec 23, 2024
View reviewed changes
domains/icvn.json Outdated Show resolved Hide resolved
@DEV-DIBSTER DEV-DIBSTER added the reason: invalid records Your records are not valid or improper. label Dec 23, 2024
@HaiYTB HaiYTB requested a review from DEV-DIBSTER December 24, 2024 05:42
orangci
orangci previously requested changes Dec 25, 2024
View reviewed changes
Copy link
Member

@orangci orangci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This site is inaccessible, please provide a preview.

@orangci orangci added reason: inaccessible website Your website is not accessible to others. and removed reason: invalid records Your records are not valid or improper. labels Dec 25, 2024
@HaiYTB
Copy link
Contributor Author

HaiYTB commented Dec 26, 2024

This site is inaccessible, please provide a preview.

It is not the address of a website. It is the address of a minecraft server.
Uploading Screenshot_2024-12-26-15-39-29-95_40deb401b9ffe8e1df2f1cc5ba480b12.jpg…

wdhdev
wdhdev previously requested changes Dec 26, 2024
View reviewed changes
domains/icvn.json Outdated Show resolved Hide resolved
@wdhdev
Copy link
Member

wdhdev commented Dec 26, 2024

@HaiYTB What port is your server running on? You should add an SRV record.

@HaiYTB
Copy link
Contributor Author

HaiYTB commented Dec 26, 2024

@HaiYTB What port is your server running on? You should add an SRV record.

Ok

@HaiYTB HaiYTB requested review from wdhdev and orangci December 26, 2024 08:48
iostpa
iostpa previously requested changes Dec 27, 2024
View reviewed changes
domains/icvn.json Outdated Show resolved Hide resolved
@iostpa iostpa added the reason: invalid records Your records are not valid or improper. label Dec 27, 2024
@iostpa
Copy link
Member

iostpa commented Dec 27, 2024

Also server seems to be offline?

@HaiYTB
Copy link
Contributor Author

HaiYTB commented Dec 27, 2024

Also server seems to be offline?

Uploading Screenshot_2024-12-27-20-34-44-70_40deb401b9ffe8e1df2f1cc5ba480b12.jpg…
It has been running for 2 days

@HaiYTB HaiYTB requested a review from iostpa December 27, 2024 13:52
@HaiYTB
Copy link
Contributor Author

HaiYTB commented Dec 29, 2024

I found the cause. It was not running because the query was not working (even though I had it enabled)

@DEV-DIBSTER DEV-DIBSTER dismissed stale reviews from iostpa, wdhdev, and orangci January 1, 2025 16:48

Outdated

@DEV-DIBSTER DEV-DIBSTER merged commit 941767e into is-a-dev:main Jan 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DEV-DIBSTER DEV-DIBSTER DEV-DIBSTER approved these changes

@wdhdev wdhdev Awaiting requested review from wdhdev

@orangci orangci Awaiting requested review from orangci

@iostpa iostpa Awaiting requested review from iostpa

Assignees
No one assigned
Labels
domain reason: inaccessible website Your website is not accessible to others. reason: invalid records Your records are not valid or improper.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HaiYTB @wdhdev @iostpa @DEV-DIBSTER @orangci