Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manish-madi #17870

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

manish-madi #17870

wants to merge 3 commits into from

Conversation

m-manish03
Copy link

@m-manish03 m-manish03 commented Dec 27, 2024 •
edited
Loading

Requirements

Unless explicitly specified otherwise by a maintainer or in the requirement description, your domain must pass ALL the indicated requirements above.

Please note that we reserve the rights not to accept any domain at our own discretion.

  • The file is in the domains folder and is in the JSON format.
  • The file's name is all lowercased and alphanumeric.
  • You have completed your website.
  • The website is reachable.
  • The CNAME record doesn't contain https:// or /.
  • There is sufficient information at the owner field.

Website Link/Preview

@m-manish03 m-manish03 requested a review from wdhdev as a code owner December 27, 2024 10:10
@m-manish03
Copy link
Author

manish-madi

iostpa
iostpa requested changes Dec 27, 2024
View reviewed changes
Copy link
Member

@iostpa iostpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Site is not accessible, please give a preview of your website.

manish-madi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File needs to be in the "domains" directory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File needs to be in the "domains" directory.

also it needs to be .json

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, didn't notice that.

@iostpa iostpa added reason: invalid file Your file is invalid or improper. status: needs preview labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustDeveloper1 JustDeveloper1 JustDeveloper1 left review comments

@iostpa iostpa iostpa requested changes

@wdhdev wdhdev Awaiting requested review from wdhdev wdhdev is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
reason: invalid file Your file is invalid or improper. status: needs preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-manish03 @iostpa @JustDeveloper1