chore(deps): Update @aws-sdk client libraries

[AndesKrrrrrrrrrrr]

Depends on #16890.

Merged to main, was broken, trying again.

• Remove unused script
• Simplify deploy-feature comment generation
• Remove unused Dockerfile

This reverts commit af1d531.

Summary by CodeRabbit

• Dependency Updates

  • Updated multiple AWS SDK packages to latest versions (3.687.0)
  • Added new AWS SDK abort controller package

• Code Maintenance

  • Reorganized import statements across multiple Contentful app components
  • Minor type corrections in test files

• No Functional Changes

  • No significant changes to application logic or user experience were introduced

[coderabbitai]

Walkthrough

This pull request involves multiple updates across various files, primarily focusing on dependency version updates in package.json and reorganization of import statements in several TypeScript/React components. The most significant change is the update of multiple AWS SDK packages from version 3.662.0 to 3.687.0, including additions like @aws-sdk/abort-controller. Additionally, numerous Contentful app components have had their import statements reordered without changing their core functionality.

Changes

File	Change Summary
infra/package.json	Updated @aws-sdk/client-ssm from 3.145.0 to 3.687.0
package.json	Updated multiple AWS SDK packages from 3.662.0 to 3.687.0 Added @aws-sdk/[email protected]
apps/contentful-apps/components/*	Reordered import statements in multiple components
apps/financial-aid/backend/src/app/modules/staff/test/numberOfUsersForMunicipality.spec.ts	Updated type from Number to number

Possibly related PRs

• chore(deps): Update @aws-sdk client libraries #16839: Updates @aws-sdk/client-ssm dependency from 3.145.0 to 3.687.0
• revert: Update @aws-sdk client libraries (#16839)" #16884: Reverts @aws-sdk/client-ssm version back to 3.145.0

Suggested Labels

automerge, high priority

Suggested Reviewers

• lodmfjord
• unakb
• thorhildurt

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.

Project coverage is 35.44%. Comparing base (3a496da) to head (78c5c3e).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...app/modules/samgongustofa/samgongustofa.service.ts	50.00%	4 Missing ⚠️
...-ui/core/src/lib/DatePicker/DatePicker.stories.tsx	0.00%	3 Missing ⚠️
...lates/financial-aid/src/lib/hooks/useFileUpload.ts	0.00%	1 Missing ⚠️
...st-server/src/lib/httpRequestDurationMiddleware.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16887      +/-   ##
==========================================
- Coverage   35.57%   35.44%   -0.13%     
==========================================
  Files        7030     7028       -2     
  Lines      150490   151836    +1346     
  Branches    42974    43838     +864     
==========================================
+ Hits        53536    53818     +282     
- Misses      96954    98018    +1064     

Flag	Coverage Δ
air-discount-scheme-backend	48.15% <0.00%> (ø)
air-discount-scheme-web	0.00% <ø> (ø)
api	3.33% <ø> (ø)
api-catalogue-services	75.81% <ø> (ø)
api-domains-air-discount-scheme	37.90% <ø> (ø)
api-domains-assets	26.71% <ø> (ø)
api-domains-auth-admin	48.49% <ø> (ø)
api-domains-communications	39.48% <ø> (ø)
api-domains-criminal-record	47.81% <ø> (ø)
api-domains-driving-license	44.77% <ø> (ø)
api-domains-education	31.09% <ø> (ø)
api-domains-health-insurance	35.19% <ø> (ø)
api-domains-payment-schedule	42.04% <ø> (ø)
application-api-files	61.80% <ø> (ø)
application-core	75.68% <ø> (ø)
application-system-api	38.67% <66.66%> (-0.01%)	⬇️
application-template-api-modules	27.54% <ø> (-0.03%)	⬇️
application-templates-accident-notification	27.60% <ø> (ø)
application-templates-car-recycling	3.12% <ø> (ø)
application-templates-criminal-record	25.79% <ø> (ø)
application-templates-driving-license	18.15% <ø> (ø)
application-templates-estate	13.58% <0.00%> (ø)
application-templates-example-payment	24.66% <ø> (ø)
application-templates-financial-aid	14.99% <0.00%> (+0.06%)	⬆️
application-templates-general-petition	23.11% <ø> (ø)
application-templates-inheritance-report	6.59% <ø> (ø)
application-templates-marriage-conditions	14.80% <ø> (ø)
application-templates-mortgage-certificate	43.73% <ø> (ø)
application-templates-new-primary-school	21.02% <ø> (ø)
clients-driving-license	40.68% <ø> (ø)
clients-driving-license-book	43.75% <ø> (ø)
clients-financial-statements-inao	49.48% <ø> (ø)
clients-license-client	1.26% <ø> (ø)
clients-middlewares	73.06% <ø> (ø)
clients-regulations	42.75% <ø> (ø)
clients-rsk-company-registry	31.18% <ø> (ø)
clients-rsk-personal-tax-return	38.32% <ø> (ø)
clients-smartsolutions	12.77% <ø> (ø)
clients-syslumenn	49.18% <ø> (ø)
clients-zendesk	49.88% <ø> (ø)
cms	0.39% <ø> (ø)
cms-translations	38.81% <ø> (ø)
content-search-index-manager	95.65% <ø> (ø)
content-search-toolkit	8.16% <ø> (ø)
contentful-apps	4.56% <ø> (ø)
dokobit-signing	61.66% <ø> (ø)
email-service	59.68% <ø> (ø)
feature-flags	90.40% <ø> (ø)
file-storage	45.32% <ø> (ø)
financial-aid-backend	51.38% <ø> (ø)
financial-aid-shared	17.88% <ø> (ø)
icelandic-names-registry-backend	54.44% <0.00%> (ø)
island-ui-core	30.32% <40.00%> (ø)
judicial-system-api	20.07% <ø> (ø)
judicial-system-audit-trail	68.53% <ø> (ø)
judicial-system-backend	55.81% <ø> (ø)
judicial-system-formatters	78.86% <ø> (ø)
judicial-system-scheduler	71.24% <ø> (ø)
judicial-system-types	37.77% <ø> (ø)
judicial-system-web	27.97% <0.00%> (ø)
license-api	42.91% <0.00%> (-0.08%)	⬇️
localization	10.15% <ø> (ø)
logging	58.02% <ø> (ø)
message-queue	67.76% <ø> (ø)
nest-audit	65.78% <ø> (ø)
nest-aws	51.93% <ø> (ø)
nest-config	76.05% <ø> (ø)
nest-core	53.16% <ø> (ø)
nest-feature-flags	50.69% <ø> (ø)
nest-problem	45.64% <0.00%> (ø)
nest-sequelize	94.44% <ø> (ø)
nest-swagger	51.13% <ø> (ø)
nova-sms	60.96% <ø> (ø)
portals-admin-regulations-admin	1.80% <ø> (ø)
portals-core	19.60% <0.00%> (ø)
regulations	16.78% <ø> (ø)
residence-history	85.00% <ø> (ø)
services-auth-admin-api	52.47% <0.00%> (ø)
services-auth-delegation-api	58.39% <0.00%> (ø)
services-auth-ids-api	52.48% <0.00%> (-0.02%)	⬇️
services-auth-public-api	49.36% <0.00%> (ø)
services-sessions	65.33% <0.00%> (ø)
services-university-gateway	49.46% <0.00%> (+0.11%)	⬆️
services-user-notification	46.52% <0.00%> (ø)
services-user-profile	56.83% <0.00%> (ø)
shared-components	29.47% <50.00%> (ø)
shared-form-fields	33.36% <0.00%> (ø)
shared-mocking	58.64% <ø> (ø)
shared-pii	92.85% <ø> (ø)
shared-problem	87.50% <ø> (ø)
shared-utils	28.67% <ø> (ø)
skilavottord-ws	23.97% <50.00%> (ø)
web	2.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...uth-admin-web/components/Admin/nav/AdminTabNav.tsx	0.00% <ø> (ø)
...h-admin-web/components/Client/nav/ClientTabNav.tsx	0.00% <ø> (ø)
apps/contentful-apps/components/Layout.tsx	0.00% <ø> (ø)
...ps/contentful-apps/components/LocalhostWarning.tsx	0.00% <ø> (ø)
...nts/MideindTranslationSidebar/fieldUtils/index.tsx	0.00% <ø> (ø)
...ul-apps/pages/fields/active-translations-field.tsx	0.00% <ø> (ø)
...entful-apps/pages/fields/admin-only-json-field.tsx	0.00% <ø> (ø)
...elds/admin-only-short-text-checkbox-list-field.tsx	0.00% <ø> (ø)
...es/fields/admin-only-short-text-dropdown-field.tsx	0.00% <ø> (ø)
...-apps/pages/fields/admin-only-short-text-field.tsx	0.00% <ø> (ø)
... and 21 more

... and 107 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a496da...78c5c3e. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs fa46579 🔗

✅ 10 Total Test Services: 0 Failed, 10 Passed
🔻 Test Sessions change in coverage: 3 decreased, 3 increased, 194 no change

Test Services

This report shows up to 10 services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
air-discount-scheme-backend	0	0	0	63	0	31.07s	N/A	Link
air-discount-scheme-web	0	0	0	2	0	7.36s	N/A	Link
api	0	0	0	4	0	3.54s	N/A	Link
api-catalogue-services	0	0	0	23	0	9.25s	N/A	Link
api-domains-air-discount-scheme	0	0	0	6	0	19.49s	N/A	Link
api-domains-assets	0	0	0	3	0	13.13s	N/A	Link
api-domains-auth-admin	0	0	0	18	0	11.33s	N/A	Link
api-domains-communications	0	0	0	5	0	34.28s	N/A	Link
api-domains-criminal-record	0	0	0	5	0	10.12s	N/A	Link
api-domains-driving-license	0	0	0	23	0	44.69s	N/A	Link

🔻 Code Coverage Decreases vs Default Branch (3)

• services-auth-delegation-api - jest 50.41% (-0.04%) - Details
• services-user-profile - jest 49.23% (-0.02%) - Details
• application-template-api-modules - jest 30.02% (-0.01%) - Details

[peturgq]

Makes sense to move this out of docker, good job 👍

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)

.github/workflows/push.yml (1)

661-670: LGTM with a suggestion for improved error handling.

The Docker build step correctly sets up the build arguments and executes the build script. However, consider adding error handling for the case when environment variables are undefined.

 - name: Docker build and push helm-config image
   working-directory: infra
   env:
     PUBLISH: 'true'
   run: |
     set -euxo pipefail
+    : "${DOCKER_BASE_IMAGE_REGISTRY:?Required environment variable is not set}"
+    : "${NODE_IMAGE_TAG:?Required environment variable is not set}"
     echo Registry is: ${{env.DOCKER_BASE_IMAGE_REGISTRY}}
     echo Image tag is: ${{env.NODE_IMAGE_TAG}}
     export EXTRA_DOCKER_BUILD_ARGS="--build-arg DOCKER_IMAGE_REGISTRY=${{env.DOCKER_BASE_IMAGE_REGISTRY}} --build-arg NODE_IMAGE_TAG=${{env.NODE_IMAGE_TAG}}"
     ./scripts/build-docker-container.sh "$DOCKER_TAG"

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 3583b64 and f5ecea3.

📒 Files selected for processing (3)

• .github/workflows/push.yml (2 hunks)
• infra/scripts/Dockerfile (1 hunks)
• infra/scripts/build-docker-container.sh (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• infra/scripts/Dockerfile
• infra/scripts/build-docker-container.sh

[AndesKrrrrrrrrrrr]

Low value, high risk, everything affected. Closed.

[AndesKrrrrrrrrrrr]

Re-opening because it's still useful, and runners are less congested now.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (3)

apps/financial-aid/backend/src/app/modules/staff/test/numberOfUsersForMunicipality.spec.ts (1)

Line range hint 1-89: Consider enhancing test maintainability.

While the tests are well-structured, consider these improvements for better maintainability:

1. Extract test constants to a separate configuration object
2. Add type assertions for the mock functions to improve type safety
3. Consider using test data builders for complex objects

Example implementation:

// Test configuration
const TEST_CONFIG = {
  DEFAULT_MUNICIPALITY_ID: uuid(),
  MOCK_USER_COUNT: 10,
  ERROR_MESSAGE: 'Some error'
} as const;

// Type-safe mock helper
const createMockStaffModel = () => {
  const mockCount = jest.fn() as jest.MockedFunction<typeof StaffModel.count>;
  return {
    ...StaffModel,
    count: mockCount
  };
};

apps/auth-admin-web/components/Client/nav/ClientTabNav.tsx (2)

Line range hint 24-39: Enhance accessibility for tab navigation.

While the component follows React best practices, it could benefit from improved accessibility features for the tab navigation.

Consider these improvements:

1. Add role="tablist" to the <ul> element
2. Add role="tab" to each button
3. Add aria-selected attribute to indicate the active tab
4. Use aria-controls to associate each tab with its panel

Example implementation:

-        <ul>
+        <ul role="tablist">
           <li className={activetab === ClientTab.BasicForm ? 'active' : ''}>
             <button
               type="button"
+              role="tab"
+              aria-selected={activetab === ClientTab.BasicForm}
               onClick={() => handleTabChange(ClientTab.BasicForm)}
               className={activetab === ClientTab.BasicForm ? 'active' : ''}

---

Line range hint 6-9: Strengthen type safety for the activeTab prop.

The optional activeTab prop could lead to undefined behavior if not properly handled.

Consider making the prop required or providing a default value:

 interface Props {
   handleTabChange: (tab: ClientTab) => void
-  activeTab?: ClientTab
+  activeTab: ClientTab
 }

Or provide a default prop value:

ClientTabNav.defaultProps = {
  activeTab: ClientTab.BasicForm,
}

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a20e792 and 78c5c3e.

📒 Files selected for processing (22)

• apps/auth-admin-web/components/Admin/nav/AdminTabNav.tsx (1 hunks)
• apps/auth-admin-web/components/Client/nav/ClientTabNav.tsx (1 hunks)
• apps/contentful-apps/components/Layout.tsx (1 hunks)
• apps/contentful-apps/components/LocalhostWarning.tsx (1 hunks)
• apps/contentful-apps/components/MideindTranslationSidebar/fieldUtils/index.tsx (1 hunks)
• apps/contentful-apps/pages/fields/active-translations-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/admin-only-json-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/admin-only-short-text-checkbox-list-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/admin-only-short-text-dropdown-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/admin-only-short-text-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/admin-only-single-reference-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/article-related-articles-field.tsx (2 hunks)
• apps/contentful-apps/pages/fields/article-subarticles-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/content-type-notifications-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/embed-link-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/form-default-namespace-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/formatted-location-input-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/publish-date-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/theme-properties-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/time-duration-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/vacancy-contacts-field.tsx (1 hunks)
• apps/financial-aid/backend/src/app/modules/staff/test/numberOfUsersForMunicipality.spec.ts (1 hunks)

✅ Files skipped from review due to trivial changes (19)

• apps/contentful-apps/pages/fields/admin-only-json-field.tsx
• apps/contentful-apps/pages/fields/time-duration-field.tsx
• apps/contentful-apps/pages/fields/admin-only-short-text-field.tsx
• apps/contentful-apps/pages/fields/publish-date-field.tsx
• apps/contentful-apps/components/LocalhostWarning.tsx
• apps/auth-admin-web/components/Admin/nav/AdminTabNav.tsx
• apps/contentful-apps/components/MideindTranslationSidebar/fieldUtils/index.tsx
• apps/contentful-apps/pages/fields/active-translations-field.tsx
• apps/contentful-apps/pages/fields/vacancy-contacts-field.tsx
• apps/contentful-apps/pages/fields/admin-only-short-text-checkbox-list-field.tsx
• apps/contentful-apps/pages/fields/article-subarticles-field.tsx
• apps/contentful-apps/pages/fields/content-type-notifications-field.tsx
• apps/contentful-apps/pages/fields/admin-only-short-text-dropdown-field.tsx
• apps/contentful-apps/pages/fields/formatted-location-input-field.tsx
• apps/contentful-apps/pages/fields/article-related-articles-field.tsx
• apps/contentful-apps/pages/fields/theme-properties-field.tsx
• apps/contentful-apps/pages/fields/admin-only-single-reference-field.tsx
• apps/contentful-apps/pages/fields/embed-link-field.tsx
• apps/contentful-apps/components/Layout.tsx

🧰 Additional context used

📓 Path-based instructions (3)

apps/auth-admin-web/components/Client/nav/ClientTabNav.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

apps/financial-aid/backend/src/app/modules/staff/test/numberOfUsersForMunicipality.spec.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

apps/contentful-apps/pages/fields/form-default-namespace-field.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

🔇 Additional comments (2)

apps/financial-aid/backend/src/app/modules/staff/test/numberOfUsersForMunicipality.spec.ts (1)

9-9: Good improvement on type usage!

The change from Number to number follows TypeScript best practices by using the primitive type instead of the wrapper object type. This improves type safety and reduces potential boxing/unboxing operations.

apps/contentful-apps/pages/fields/form-default-namespace-field.tsx (1)

2-2: LGTM! Import organization follows best practices.

The reorganization of imports improves code organization while maintaining proper type safety with the SDK. The component demonstrates good TypeScript practices and follows NextJS conventions.

Also applies to: 7-9

[coderabbitai]

🛠️ Refactor suggestion

Follow TypeScript naming conventions.

The prop rename from activeTab to activetab breaks the camelCase naming convention commonly used in TypeScript/React. This inconsistency could lead to confusion and maintenance issues.

Apply this diff to maintain consistent naming:

 const ClientTabNav: React.FC<React.PropsWithChildren<Props>> = ({
   handleTabChange,
-  activeTab: activetab,
+  activeTab,
   children,
 }) => {

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	handleTabChange,
	activeTab: activetab,
	children,
	handleTabChange,
	activeTab,
	children,