chore(web): Electronic registrations - Remove unused component and relevant endpoints #17357

RunarVestmann · 2024-12-27T11:33:33Z

Electronic registrations - Remove unused component and relevant endpoints

What

Unused endpoints and unused component, let's remove them from the monorepo

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Formatting passes locally with my changes
I have rebased against main before asking for a review

Summary by CodeRabbit

Release Notes

Bug Fixes
- Removed ownership entries for the electronic-registration-statistics domain.
- Eliminated the ELECTRONIC_REGISTRATION_STATISTICS_API_URL configuration across various services.
New Features
- Comprehensive updates to service configurations, including health checks and Horizontal Pod Autoscaler settings.
Documentation
- Removed README files for both the electronic registration statistics API and client libraries, eliminating guidance on usage and configuration.
Refactor
- Deleted multiple modules and components related to electronic registration statistics, including services, resolvers, and GraphQL input types.
- Removed style definitions and components associated with electronic registration statistics visualizations.

coderabbitai · 2024-12-27T11:33:41Z

Walkthrough

This pull request involves a comprehensive removal of the electronic registration statistics functionality across multiple libraries and components. The changes include deleting entire modules, services, configurations, and related components from both the API and client libraries. The removal spans configuration files, TypeScript modules, GraphQL resolvers, and frontend components related to electronic registration statistics.

Changes

File/Path	Change Summary
`.github/CODEOWNERS`	Removed entries for electronic registration statistics domain paths
`apps/api/infra/api.ts`	Removed `ELECTRONIC_REGISTRATION_STATISTICS_API_URL` configuration
`apps/api/src/app/app.module.ts`	Removed `ElectronicRegistrationsModule` and `ElectronicRegistrationsClientConfig`
`apps/web/components/connected/electronicRegistrationStatistics/`	Deleted entire directory with all related components and utilities
`libs/api/domains/electronic-registration-statistics/`	Removed entire library with all configuration and source files
`libs/clients/electronic-registration-statistics/`	Removed entire client library with all configuration and source files
Various `charts/islandis/values.*.yaml`	Removed `ELECTRONIC_REGISTRATION_STATISTICS_API_URL` environment variable

Suggested reviewers

robertaandersen
svanaeinars

Possibly related PRs

chore(system-e2e): Move system test ownership to relevant teams #16479: This PR also modifies the .github/CODEOWNERS file, indicating changes in ownership assignments, which may relate to the restructuring of responsibilities for the electronic registration statistics domain.
chore(University-Gateway): Change ownership of UG queries #16634: This PR updates the .github/CODEOWNERS file, adding new ownership entries, which is relevant to the changes made in the main PR regarding ownership removal for specific domains.
chore(codeowners): modify ownership of health directorate clients #16904: This PR modifies the .github/CODEOWNERS file, adjusting ownership structures, which aligns with the ownership changes made in the main PR.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f8e41a2 and 856233e.

⛔ Files ignored due to path filters (1)

libs/cms/src/lib/generated/contentfulTypes.d.ts is excluded by !**/generated/**

📒 Files selected for processing (1)

apps/web/utils/richText.tsx (0 hunks)

💤 Files with no reviewable changes (1)

apps/web/utils/richText.tsx

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: prepare
GitHub Check: helm-values-validation

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-12-27T11:52:20Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.69%. Comparing base (56d6e6e) to head (856233e).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17357      +/-   ##
==========================================
+ Coverage   35.67%   35.69%   +0.01%     
==========================================
  Files        6932     6927       -5     
  Lines      148878   148805      -73     
  Branches    42538    42515      -23     
==========================================
+ Hits        53107    53109       +2     
+ Misses      95771    95696      -75

Flag	Coverage Δ
air-discount-scheme-backend	`48.24% <ø> (ø)`
air-discount-scheme-web	`0.00% <ø> (ø)`
api	`3.35% <ø> (+0.02%)`	⬆️
api-catalogue-services	`75.81% <ø> (ø)`
api-domains-air-discount-scheme	`37.99% <ø> (ø)`
api-domains-assets	`26.71% <ø> (ø)`
api-domains-auth-admin	`48.49% <ø> (ø)`
api-domains-communications	`39.39% <ø> (ø)`
api-domains-criminal-record	`48.03% <ø> (ø)`
api-domains-health-insurance	`35.47% <ø> (ø)`
api-domains-mortgage-certificate	`35.24% <ø> (ø)`
api-domains-payment-schedule	`42.12% <ø> (ø)`
application-api-files	`61.90% <ø> (ø)`
application-core	`75.72% <ø> (ø)`
application-system-api	`38.73% <ø> (+0.01%)`	⬆️
application-template-api-modules	`27.67% <ø> (-0.01%)`	⬇️
application-templates-accident-notification	`27.61% <ø> (ø)`
application-templates-car-recycling	`3.12% <ø> (ø)`
application-templates-criminal-record	`25.83% <ø> (ø)`
application-templates-driving-license	`18.15% <ø> (ø)`
application-templates-estate	`13.67% <ø> (ø)`
application-templates-example-payment	`24.69% <ø> (ø)`
application-templates-financial-aid	`14.45% <ø> (ø)`
application-templates-general-petition	`23.12% <ø> (ø)`
application-templates-inheritance-report	`6.57% <ø> (ø)`
application-templates-marriage-conditions	`15.18% <ø> (ø)`
application-templates-mortgage-certificate	`43.68% <ø> (ø)`
application-templates-parental-leave	`29.92% <ø> (ø)`
application-types	`6.51% <ø> (ø)`
application-ui-components	`1.22% <ø> (ø)`
application-ui-shell	`22.26% <ø> (ø)`
auth-admin-web	`2.43% <ø> (ø)`
auth-nest-tools	`31.52% <ø> (ø)`
auth-shared	`75.00% <ø> (ø)`
clients-charge-fjs-v2	`28.88% <ø> (ø)`
clients-driving-license	`40.91% <ø> (ø)`
clients-driving-license-book	`43.92% <ø> (ø)`
clients-financial-statements-inao	`49.70% <ø> (ø)`
clients-license-client	`1.26% <ø> (ø)`
clients-middlewares	`72.93% <ø> (ø)`
clients-regulations	`43.00% <ø> (ø)`
clients-rsk-company-registry	`31.18% <ø> (ø)`
clients-rsk-personal-tax-return	`38.32% <ø> (ø)`
clients-smartsolutions	`12.77% <ø> (ø)`
clients-syslumenn	`49.47% <ø> (ø)`
clients-zendesk	`50.58% <ø> (ø)`
cms	`0.39% <ø> (ø)`
cms-translations	`38.73% <ø> (ø)`
content-search-index-manager	`95.65% <ø> (ø)`
content-search-toolkit	`8.16% <ø> (ø)`
contentful-apps	`4.69% <ø> (ø)`
dokobit-signing	`62.18% <ø> (ø)`
email-service	`60.15% <ø> (ø)`
feature-flags	`90.83% <ø> (ø)`
file-storage	`45.97% <ø> (ø)`
financial-aid-backend	`51.42% <ø> (ø)`
financial-aid-shared	`17.88% <ø> (ø)`
icelandic-names-registry-backend	`54.33% <ø> (ø)`
infra-nest-server	`48.06% <ø> (ø)`
infra-tracing	`69.94% <ø> (ø)`
island-ui-core	`30.34% <ø> (ø)`
judicial-system-api	`20.20% <ø> (ø)`
judicial-system-audit-trail	`69.02% <ø> (ø)`
judicial-system-backend	`55.91% <ø> (ø)`
judicial-system-formatters	`78.50% <ø> (ø)`
judicial-system-message	`66.60% <ø> (ø)`
judicial-system-message-handler	`48.33% <ø> (ø)`
judicial-system-scheduler	`71.15% <ø> (ø)`
judicial-system-types	`41.60% <ø> (ø)`
judicial-system-web	`27.75% <ø> (ø)`
license-api	`42.94% <ø> (-0.06%)`	⬇️
localization	`10.15% <ø> (ø)`
logging	`58.02% <ø> (ø)`
message-queue	`67.76% <ø> (+0.70%)`	⬆️
nest-audit	`65.78% <ø> (ø)`
nest-aws	`51.93% <ø> (ø)`
nest-config	`76.45% <ø> (ø)`
nest-core	`53.16% <ø> (ø)`
nest-feature-flags	`51.06% <ø> (ø)`
nest-problem	`45.64% <ø> (ø)`
nest-sequelize	`94.44% <ø> (ø)`
nest-swagger	`51.13% <ø> (ø)`
nova-sms	`61.52% <ø> (ø)`
portals-admin-regulations-admin	`1.80% <ø> (ø)`
portals-core	`19.58% <ø> (ø)`
regulations	`16.78% <ø> (ø)`
services-auth-admin-api	`52.54% <ø> (ø)`
services-auth-delegation-api	`58.47% <ø> (-0.01%)`	⬇️
services-auth-ids-api	`52.56% <ø> (-0.01%)`	⬇️
services-auth-public-api	`49.43% <ø> (ø)`
services-sessions	`65.32% <ø> (ø)`
services-university-gateway	`49.46% <ø> (ø)`
services-user-notification	`46.50% <ø> (ø)`
services-user-profile	`56.97% <ø> (ø)`
shared-components	`29.49% <ø> (ø)`
shared-form-fields	`33.37% <ø> (ø)`
shared-mocking	`58.64% <ø> (ø)`
shared-pii	`92.85% <ø> (ø)`
shared-problem	`87.50% <ø> (ø)`
shared-utils	`27.69% <ø> (ø)`
skilavottord-ws	`24.26% <ø> (ø)`
web	`2.41% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
apps/api/src/app/app.module.ts	`0.00% <ø> (ø)`
apps/web/utils/richText.tsx	`0.00% <ø> (ø)`

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56d6e6e...856233e. Read the comment docs.

robertaandersen

LGTM

datadog-island-is · 2024-12-27T12:11:31Z

Datadog Report

All test runs 09d59fb 🔗

❌ 10 Total Test Services: 1 Failed, 9 Passed
🔻 Test Sessions change in coverage: 2 decreased, 2 increased, 196 no change

Test Services

This report shows up to 10 services

Service Name	Failed	Passed	Total Time	Code Coverage Change	Test Service View
`api-domains-driving-license`	3	20	27.88s	N/A	Link
`air-discount-scheme-backend`	0	63	22.46s	N/A	Link
`air-discount-scheme-web`	0	2	6.58s	N/A	Link
`api`	0	4	2.7s	N/A	Link
`api-catalogue-services`	0	23	11.1s	N/A	Link
`api-domains-air-discount-scheme`	0	6	20.01s	N/A	Link
`api-domains-assets`	0	3	12.03s	N/A	Link
`api-domains-auth-admin`	0	18	13.28s	1 no change	Link
`api-domains-communications`	0	5	30.65s	N/A	Link
`api-domains-criminal-record`	0	5	8.37s	N/A	Link

❌ Failed Tests (3)

DrivingLicenseService getApplicationEligibility all checks should pass for applicable students - libs/api/domains/driving-license/src/lib/drivingLicense.spec.ts - Details

Expand for error

 expect(received).toStrictEqual(expected) // deep equality
 
 - Expected  - 1
 + Received  + 1
 
 @@ -8,11 +8,11 @@
       Object {
         "key": "DrivingSchoolMissing",
         "requirementMet": true,
       },
 ...

DrivingLicenseService getApplicationEligibility all checks should pass for applicable students for temporary license - libs/api/domains/driving-license/src/lib/drivingLicense.spec.ts - Details

Expand for error

 expect(received).toStrictEqual(expected) // deep equality
 
 - Expected  - 1
 + Received  + 1
 
 @@ -1,10 +1,10 @@
   Object {
     "isEligible": true,
     "requirements": Array [
       Object {
 ...

DrivingLicenseService getApplicationEligibility checks should fail for non-applicable students - libs/api/domains/driving-license/src/lib/drivingLicense.spec.ts - Details

Expand for error

 expect(received).toStrictEqual(expected) // deep equality
 
 - Expected  - 1
 + Received  + 1
 
 @@ -8,11 +8,11 @@
       Object {
         "key": "DrivingSchoolMissing",
         "requirementMet": false,
       },
 ...

🔻 Code Coverage Decreases vs Default Branch (2)

services-auth-delegation-api - jest 50.45% (-0.02%) - Details
license-api - jest 34.12% (-0.01%) - Details

magnearun

Core files lgtm

kodiakhq · 2025-01-04T06:17:05Z

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

…ion-statistic-component

RunarVestmann added 2 commits December 27, 2024 11:30

Remove unused component and relevant endpoints

6d5bc25

Remove deleted files from CODEOWNERS file

6f3f1f8

RunarVestmann added the automerge Merge this PR as soon as all checks pass label Dec 27, 2024

RunarVestmann requested review from a team as code owners December 27, 2024 11:33

coderabbitai bot approved these changes Dec 27, 2024

View reviewed changes

robertaandersen approved these changes Dec 27, 2024

View reviewed changes

magnearun approved these changes Jan 2, 2025

View reviewed changes

mannipje approved these changes Jan 3, 2025

View reviewed changes

kodiakhq bot removed the automerge Merge this PR as soon as all checks pass label Jan 4, 2025

Merge branch 'main' into chore/web-remove-unused-electronig-registrat…

7272c3e

…ion-statistic-component

RunarVestmann force-pushed the chore/web-remove-unused-electronig-registration-statistic-component branch from a5abed3 to 7272c3e Compare January 6, 2025 09:31

chore: charts update dirty files

f8e41a2

RunarVestmann added the automerge Merge this PR as soon as all checks pass label Jan 6, 2025

Merge branch 'main' into chore/web-remove-unused-electronig-registrat…

06802a6

…ion-statistic-component

RunarVestmann added automerge Merge this PR as soon as all checks pass and removed automerge Merge this PR as soon as all checks pass labels Jan 6, 2025

Merge branch 'main' into chore/web-remove-unused-electronig-registrat…

ab40d44

…ion-statistic-component

oddsson added automerge Merge this PR as soon as all checks pass and removed automerge Merge this PR as soon as all checks pass labels Jan 6, 2025

Merge branch 'main' into chore/web-remove-unused-electronig-registrat…

856233e

…ion-statistic-component

RunarVestmann removed the automerge Merge this PR as soon as all checks pass label Jan 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(web): Electronic registrations - Remove unused component and relevant endpoints #17357

chore(web): Electronic registrations - Remove unused component and relevant endpoints #17357

RunarVestmann commented Dec 27, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 27, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Dec 27, 2024 •

edited

Loading

robertaandersen left a comment

datadog-island-is bot commented Dec 27, 2024 •

edited

Loading

magnearun left a comment

kodiakhq bot commented Jan 4, 2025

chore(web): Electronic registrations - Remove unused component and relevant endpoints #17357

Are you sure you want to change the base?

chore(web): Electronic registrations - Remove unused component and relevant endpoints #17357

Conversation

RunarVestmann commented Dec 27, 2024 • edited by coderabbitai bot Loading

Electronic registrations - Remove unused component and relevant endpoints

What

Checklist:

Summary by CodeRabbit

Release Notes

coderabbitai bot commented Dec 27, 2024 • edited Loading

Walkthrough

Changes

Suggested reviewers

Possibly related PRs

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Dec 27, 2024 • edited Loading

Codecov Report

robertaandersen left a comment

Choose a reason for hiding this comment

datadog-island-is bot commented Dec 27, 2024 • edited Loading

Datadog Report

❌ Failed Tests (3)

🔻 Code Coverage Decreases vs Default Branch (2)

magnearun left a comment

Choose a reason for hiding this comment

kodiakhq bot commented Jan 4, 2025

RunarVestmann commented Dec 27, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 27, 2024 •

edited

Loading

codecov bot commented Dec 27, 2024 •

edited

Loading

datadog-island-is bot commented Dec 27, 2024 •

edited

Loading