chore(web): Remove NewLinks component

[RunarVestmann]

Remove NewLinks component

What

isn't being used anywhere so I suggest we remove it

Why

• Code that isn't being used shouldn't exist in the monorepo.
• If we ever want to use this component again we can look at the git history and bring the files back

(Screenshot I took here: https://web.archive.org/web/20220308133147/https://island.is/)

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• Removal

  • Deleted NewLinks component and its associated CSS styles
  • Removed NewLinks export from shared components module

• Component Updates

  • Updated Home screen with new imports and component structure
  • Added support for locale-specific rendering
  • Enhanced news item fetching and display logic

The changes primarily involve removing a specific component and refactoring the home screen's component architecture.

[coderabbitai]

Walkthrough

The pull request involves the removal of the NewLinks component and its associated CSS styles from the web application. The changes primarily affect the Home.tsx screen, where import statements and component usage have been restructured. The home page now incorporates new components like LifeEventsSection, CategoryItems, and NewsItems to dynamically render content. The Home.getProps method has been updated to include a new query for fetching news items, with modifications to how news data is processed and filtered.

Changes

File	Change Summary
apps/web/components/NewLinks/NewLinks.css.ts	Deleted CSS styles file with responsive design definitions
apps/web/components/NewLinks/NewLinks.tsx	Removed React component for displaying links with dates
apps/web/components/real.ts	Removed export for NewLinks component
apps/web/screens/Home/Home.tsx	Updated imports, added new components, modified getProps method to include news query

Possibly related PRs

• feat(web): Remove front page news #15221: Removal of news ticker section related to component restructuring
• feat(web): updated grant status logic #17127: Updates to component rendering logic for links and statuses

Suggested labels

automerge

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 56493cc and e73526c.

📒 Files selected for processing (4)

• apps/web/components/NewLinks/NewLinks.css.ts (0 hunks)
• apps/web/components/NewLinks/NewLinks.tsx (0 hunks)
• apps/web/components/real.ts (0 hunks)
• apps/web/screens/Home/Home.tsx (1 hunks)

💤 Files with no reviewable changes (3)

• apps/web/components/real.ts
• apps/web/components/NewLinks/NewLinks.tsx
• apps/web/components/NewLinks/NewLinks.css.ts

🧰 Additional context used

📓 Path-based instructions (1)

apps/web/screens/Home/Home.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

🔇 Additional comments (8)

apps/web/screens/Home/Home.tsx (8)

2-2: Blank line.
No additional feedback.

---

3-5: Import statements validated.
These imports correctly reference the shared schemas and UI components.

---

6-12: Well-organized imports from @island.is/web/components.
All imported components (CategoryItems, LifeEventsSection, NewsItems, SearchSection, and WatsonChatPanel) appear to be in use within Home, and this follows NextJS best practices for modular components.

---

13-13: Constant import is consistent.
FRONTPAGE_NEWS_TAG_ID is clearly referenced in the queries below.

---

14-14: GlobalContext usage.
The global context is appropriately imported and used with useContext.

---

20-21: GraphQL input type imports.
QueryGetArticleCategoriesArgs and QueryGetFrontpageArgs align well with the Apollo queries below.

---

23-24: Namespace and i18n hooks.
useNamespace and useI18n are consistently used for localized content handling, adhering to the existing code conventions.

---

31-32: Screen type import confirmed.
Using the Screen<HomeProps> pattern enforces strong typing for NextJS page components.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.69%. Comparing base (ab163c2) to head (726c5e3).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17363      +/-   ##
==========================================
+ Coverage   35.67%   35.69%   +0.01%     
==========================================
  Files        6933     6930       -3     
  Lines      148845   148701     -144     
  Branches    42523    42480      -43     
==========================================
- Hits        53098    53074      -24     
+ Misses      95747    95627     -120     

Flag	Coverage Δ
web	2.40% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab163c2...726c5e3. Read the comment docs.

[datadog-island-is]

Datadog Report

Branch report: chore/web-remove-new-links-component
Commit report: d0ec669
Test service: web

✅ 0 Failed, 84 Passed, 0 Skipped, 24.43s Total Time
➡️ Test Sessions change in coverage: 1 no change

[kodiakhq]

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.