chore(auth-api-lib): Cleanup legal repr. and general mandate feature flags. #17372
Conversation
WalkthroughThe pull request introduces changes to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🧰 Additional context used📓 Path-based instructions (1)libs/auth-api-lib/src/lib/delegations/delegations-incoming.service.ts (1)Pattern
🔇 Additional comments (3)libs/auth-api-lib/src/lib/delegations/delegations-incoming.service.ts (3)
The removal of feature flag checks means this call to
By calling
With the feature flags removed, automatically pushing this block to gather delegations from the District Commissioners Registry ensures a consistent flow. The code’s readability is improved, aligning with the cleanup goals. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
valurefugl
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17372 +/- ##
==========================================
- Coverage 35.68% 35.68% -0.01%
==========================================
Files 6931 6931
Lines 148785 148777 -8
Branches 42509 42506 -3
==========================================
- Hits 53091 53084 -7
+ Misses 95694 95693 -1 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 10 Total Test Services: 0 Failed, 10 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (26)
|
What
Cleanup unused legal representative and general mandate feature flags.
Why
So we have tidier code and can delete the flags from configcat.
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist:
Summary by CodeRabbit
Refactor
Chores