chore: test all cache #17395

brynjarorng · 2025-01-03T09:39:41Z

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Formatting passes locally with my changes
I have rebased against main before asking for a review

Summary by CodeRabbit

Chores
- Added a blank line at the end of a source file
- No functional changes to the codebase

coderabbitai · 2025-01-03T09:39:49Z

Walkthrough

The pull request involves a minor modification to the infra/src/uber-charts/islandis.ts file, specifically adding a blank line at the end of the file. This change does not introduce any functional modifications or impact the existing code's behavior. Such additions are often made to comply with coding style guidelines or to improve file readability.

Changes

File	Change Summary
`infra/src/uber-charts/islandis.ts`	Added a blank line at the end of the file

Note: No sequence diagram is generated as the change is trivial and does not modify any control flow or introduce new functionality.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between be57698 and 5133a59.

📒 Files selected for processing (1)

infra/src/uber-charts/islandis.ts (1 hunks)

✅ Files skipped from review due to trivial changes (1)

infra/src/uber-charts/islandis.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-01-03T10:40:00Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.68%. Comparing base (be57698) to head (5c551e2).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17395   +/-   ##
=======================================
  Coverage   35.68%   35.68%           
=======================================
  Files        6931     6931           
  Lines      148792   148792           
  Branches    42511    42511           
=======================================
+ Hits        53098    53100    +2     
+ Misses      95694    95692    -2

Flag	Coverage Δ
air-discount-scheme-backend	`48.24% <0.00%> (ø)`
air-discount-scheme-web	`0.00% <0.00%> (ø)`
api	`3.33% <0.00%> (ø)`
api-catalogue-services	`75.81% <0.00%> (ø)`
api-domains-air-discount-scheme	`37.99% <0.00%> (ø)`
api-domains-assets	`26.71% <0.00%> (ø)`
api-domains-auth-admin	`48.49% <0.00%> (ø)`
api-domains-communications	`39.42% <0.00%> (ø)`
api-domains-criminal-record	`48.03% <0.00%> (ø)`
api-domains-health-insurance	`35.47% <0.00%> (ø)`
api-domains-mortgage-certificate	`35.24% <0.00%> (ø)`
api-domains-payment-schedule	`42.12% <0.00%> (ø)`
application-api-files	`61.90% <0.00%> (ø)`
application-core	`75.72% <0.00%> (ø)`
application-system-api	`38.72% <0.00%> (-0.01%)`	⬇️
application-template-api-modules	`27.66% <0.00%> (-0.02%)`	⬇️
application-templates-accident-notification	`27.61% <0.00%> (ø)`
application-templates-car-recycling	`3.12% <0.00%> (ø)`
application-templates-criminal-record	`25.83% <0.00%> (ø)`
application-templates-driving-license	`18.15% <0.00%> (ø)`
application-templates-estate	`13.66% <0.00%> (ø)`
application-templates-example-payment	`24.69% <0.00%> (ø)`
application-templates-financial-aid	`14.45% <0.00%> (ø)`
application-templates-general-petition	`23.12% <0.00%> (ø)`
application-templates-inheritance-report	`6.59% <0.00%> (ø)`
application-templates-marriage-conditions	`15.18% <0.00%> (ø)`
application-templates-mortgage-certificate	`43.68% <0.00%> (ø)`
application-templates-parental-leave	`29.92% <0.00%> (-0.03%)`	⬇️
application-types	`6.51% <0.00%> (ø)`
application-ui-components	`1.22% <0.00%> (ø)`
application-ui-shell	`22.25% <0.00%> (ø)`
auth-admin-web	`2.43% <0.00%> (ø)`
auth-nest-tools	`31.52% <0.00%> (ø)`
auth-shared	`75.00% <0.00%> (ø)`
clients-charge-fjs-v2	`28.88% <0.00%> (ø)`
clients-driving-license	`40.91% <0.00%> (ø)`
clients-driving-license-book	`43.92% <0.00%> (ø)`
clients-financial-statements-inao	`49.70% <0.00%> (ø)`
clients-license-client	`1.26% <0.00%> (ø)`
clients-middlewares	`73.18% <0.00%> (+0.24%)`	⬆️
clients-regulations	`43.00% <0.00%> (ø)`
clients-rsk-company-registry	`31.18% <0.00%> (ø)`
clients-rsk-personal-tax-return	`38.32% <0.00%> (ø)`
clients-smartsolutions	`12.77% <0.00%> (ø)`
clients-zendesk	`50.58% <0.00%> (ø)`
cms	`0.39% <0.00%> (ø)`
cms-translations	`38.75% <0.00%> (ø)`
content-search-index-manager	`95.65% <0.00%> (ø)`
content-search-toolkit	`8.16% <0.00%> (ø)`
contentful-apps	`4.71% <0.00%> (ø)`
dokobit-signing	`62.18% <0.00%> (ø)`
email-service	`60.15% <0.00%> (ø)`
feature-flags	`90.83% <0.00%> (ø)`
file-storage	`45.97% <0.00%> (ø)`
financial-aid-backend	`51.42% <0.00%> (ø)`
financial-aid-shared	`17.88% <0.00%> (ø)`
infra-nest-server	`48.06% <0.00%> (ø)`
infra-tracing	`69.94% <0.00%> (ø)`
island-ui-core	`30.42% <0.00%> (ø)`
judicial-system-api	`20.20% <0.00%> (ø)`
judicial-system-audit-trail	`69.02% <0.00%> (ø)`
judicial-system-backend	`55.97% <0.00%> (-0.01%)`	⬇️
judicial-system-formatters	`78.50% <0.00%> (ø)`
judicial-system-message	`66.60% <0.00%> (ø)`
judicial-system-message-handler	`48.33% <0.00%> (ø)`
judicial-system-scheduler	`71.15% <0.00%> (ø)`
judicial-system-types	`41.60% <0.00%> (ø)`
judicial-system-web	`27.75% <0.00%> (ø)`
license-api	`42.87% <0.00%> (-0.13%)`	⬇️
localization	`10.15% <0.00%> (ø)`
logging	`58.02% <0.00%> (ø)`
message-queue	`67.76% <0.00%> (+0.70%)`	⬆️
nest-audit	`65.78% <0.00%> (ø)`
nest-aws	`51.93% <0.00%> (ø)`
nest-config	`76.45% <0.00%> (ø)`
nest-core	`53.16% <0.00%> (ø)`
nest-feature-flags	`51.06% <0.00%> (ø)`
nest-problem	`45.64% <0.00%> (ø)`
nest-sequelize	`94.44% <0.00%> (ø)`
nest-swagger	`51.13% <0.00%> (ø)`
nova-sms	`61.52% <0.00%> (ø)`
portals-admin-regulations-admin	`1.80% <0.00%> (ø)`
portals-core	`19.58% <0.00%> (ø)`
regulations	`16.78% <0.00%> (ø)`
services-auth-admin-api	`52.54% <0.00%> (ø)`
services-auth-delegation-api	`58.55% <0.00%> (+0.07%)`	⬆️
services-auth-ids-api	`52.59% <0.00%> (+0.01%)`	⬆️
services-auth-public-api	`49.43% <0.00%> (ø)`
services-sessions	`65.32% <0.00%> (ø)`
services-university-gateway	`49.52% <0.00%> (+0.05%)`	⬆️
services-user-notification	`46.54% <0.00%> (+<0.01%)`	⬆️
services-user-profile	`56.97% <0.00%> (ø)`
shared-components	`29.49% <0.00%> (ø)`
shared-form-fields	`33.38% <0.00%> (ø)`
shared-mocking	`58.64% <0.00%> (ø)`
shared-pii	`92.85% <0.00%> (ø)`
shared-problem	`87.50% <0.00%> (ø)`
shared-utils	`27.69% <0.00%> (ø)`
skilavottord-ws	`24.26% <0.00%> (ø)`
web	`2.40% <0.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be57698...5c551e2. Read the comment docs.

datadog-island-is · 2025-01-03T10:43:32Z

Datadog Report

All test runs 77cb7bd 🔗

❌ 10 Total Test Services: 1 Failed, 9 Passed
🔻 Test Sessions change in coverage: 3 decreased, 3 increased, 194 no change

Test Services

This report shows up to 10 services

Service Name	Failed	Passed	Total Time	Code Coverage Change	Test Service View
`api-domains-driving-license`	3	20	27.06s	N/A	Link
`air-discount-scheme-backend`	0	63	21.91s	N/A	Link
`air-discount-scheme-web`	0	2	6.47s	N/A	Link
`api`	0	4	2.38s	N/A	Link
`api-catalogue-services`	0	23	8.93s	N/A	Link
`api-domains-air-discount-scheme`	0	6	16.1s	N/A	Link
`api-domains-assets`	0	3	9.46s	N/A	Link
`api-domains-auth-admin`	0	18	10.05s	N/A	Link
`api-domains-communications`	0	5	30.31s	N/A	Link
`api-domains-criminal-record`	0	5	8.47s	N/A	Link

❌ Failed Tests (3)

DrivingLicenseService getApplicationEligibility all checks should pass for applicable students - libs/api/domains/driving-license/src/lib/drivingLicense.spec.ts - Details

Expand for error

 expect(received).toStrictEqual(expected) // deep equality
 
 - Expected  - 1
 + Received  + 1
 
 @@ -8,11 +8,11 @@
       Object {
         "key": "DrivingSchoolMissing",
         "requirementMet": true,
       },
 ...

DrivingLicenseService getApplicationEligibility all checks should pass for applicable students for temporary license - libs/api/domains/driving-license/src/lib/drivingLicense.spec.ts - Details

Expand for error

 expect(received).toStrictEqual(expected) // deep equality
 
 - Expected  - 1
 + Received  + 1
 
 @@ -1,10 +1,10 @@
   Object {
     "isEligible": true,
     "requirements": Array [
       Object {
 ...

DrivingLicenseService getApplicationEligibility checks should fail for non-applicable students - libs/api/domains/driving-license/src/lib/drivingLicense.spec.ts - Details

Expand for error

 expect(received).toStrictEqual(expected) // deep equality
 
 - Expected  - 1
 + Received  + 1
 
 @@ -8,11 +8,11 @@
       Object {
         "key": "DrivingSchoolMissing",
         "requirementMet": false,
       },
 ...

🔻 Code Coverage Decreases vs Default Branch (3)

license-api - jest 34.11% (-0.02%) - Details
application-system-api - jest 35.55% (-0.01%) - Details
application-template-api-modules - jest 30.06% (-0.01%) - Details

test

5133a59

brynjarorng requested a review from a team as a code owner January 3, 2025 09:39

coderabbitai bot approved these changes Jan 3, 2025

View reviewed changes

brynjarorng added the test everything 💀 test & build everything 💀 label Jan 3, 2025

chore: nx format:write update dirty files

5c551e2

brynjarorng removed the test everything 💀 test & build everything 💀 label Jan 3, 2025

Merge branch 'main' into del-me-test-all

15867b3

brynjarorng closed this Jan 6, 2025

brynjarorng deleted the del-me-test-all branch January 6, 2025 09:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: test all cache #17395

chore: test all cache #17395

brynjarorng commented Jan 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 3, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Jan 3, 2025 •

edited

Loading

datadog-island-is bot commented Jan 3, 2025

chore: test all cache #17395

chore: test all cache #17395

Conversation

brynjarorng commented Jan 3, 2025 • edited by coderabbitai bot Loading

...

What

Why

Screenshots / Gifs

Checklist:

Summary by CodeRabbit

coderabbitai bot commented Jan 3, 2025 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Jan 3, 2025 • edited Loading

Codecov Report

datadog-island-is bot commented Jan 3, 2025

Datadog Report

❌ Failed Tests (3)

🔻 Code Coverage Decreases vs Default Branch (3)

brynjarorng commented Jan 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 3, 2025 •

edited

Loading

codecov bot commented Jan 3, 2025 •

edited

Loading