Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(j-s): Order case files in descending created order #17413

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

unakb
Copy link
Member

@unakb unakb commented Jan 6, 2025

Innsend gögn - raða lista í tímaröð (nýjasta efst)

What

Order case files by descending created date

Why

So that they first get displayed in order from newest to oldest to users

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • Improvements
    • Updated case file sorting to display most recently created files first across backend services and web interface.
    • Modified default table sorting to prioritize case files by creation date in descending order.

@unakb unakb marked this pull request as ready for review January 6, 2025 13:38
@unakb unakb requested a review from a team as a code owner January 6, 2025 13:38
Copy link
Contributor

coderabbitai bot commented Jan 6, 2025

Walkthrough

The pull request introduces modifications to case file retrieval and sorting across multiple components of the judicial system application. Changes are made in the backend services (CaseService and LimitedAccessCaseService) and the frontend CaseFileTable component to consistently order case files by their creation date in descending order. This ensures that the most recently created files are prioritized and displayed first when retrieving and presenting case files.

Changes

File Change Summary
apps/judicial-system/backend/src/app/modules/case/case.service.ts Added order clause to caseFiles model to sort by created field in descending order
apps/judicial-system/backend/src/app/modules/case/limitedAccessCase.service.ts Added order clause to caseFiles model to sort by created field in descending order
apps/judicial-system/web/src/components/Table/CaseFileTable/CaseFileTable.tsx Updated default sorting from 'name' (ascending) to 'created' (descending)

Possibly related PRs

  • feat(j-s): Table for reviewed cases #14778: The changes in the LimitedAccessCaseService class regarding the include array for the caseFiles model are directly related to the modifications made in the main PR for the CaseService class, as both involve enhancements to how case files are retrieved with an order clause.
  • feat(j-s): Display connected indictment case files  #15526: The addition of new conditions and associations in the CaseService class to include related CaseFile entities aligns with the changes made in the main PR, which also modifies how case files are included in queries.
  • feat(j-s): Deliver Confirmed Indictment Ruling to Court #17104: The modifications to the addMessagesForCompletedIndictmentCaseToQueue method in the CaseService class, which now includes filtering for specific case file categories, relate to the changes in the main PR that enhance the handling of case files.

Suggested reviewers

  • unakb
  • thorhildurt

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c210203 and d9405ad.

📒 Files selected for processing (1)
  • apps/judicial-system/backend/src/app/modules/case/case.service.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/judicial-system/backend/src/app/modules/case/case.service.ts
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: prepare

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.60%. Comparing base (b249dfa) to head (d9405ad).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17413   +/-   ##
=======================================
  Coverage   35.60%   35.60%           
=======================================
  Files        7019     7019           
  Lines      150408   150408           
  Branches    42961    42961           
=======================================
  Hits        53553    53553           
  Misses      96855    96855           
Flag Coverage Δ
judicial-system-web 27.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ystem/backend/src/app/modules/case/case.service.ts 88.62% <ø> (ø)
.../src/app/modules/case/limitedAccessCase.service.ts 72.56% <ø> (ø)
...c/components/Table/CaseFileTable/CaseFileTable.tsx 7.69% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b249dfa...d9405ad. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Jan 6, 2025

Datadog Report

All test runs 3ccc2a5 🔗

2 Total Test Services: 0 Failed, 2 Passed
➡️ Test Sessions change in coverage: 2 no change

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
judicial-system-backend 0 0 0 21360 0 18m 32.67s 1 no change Link
judicial-system-web 0 0 0 333 0 58.06s 1 no change Link

@oddsson oddsson added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Jan 16, 2025
@kodiakhq kodiakhq bot merged commit e2c586b into main Jan 17, 2025
38 checks passed
@kodiakhq kodiakhq bot deleted the j-s/order-indictment-case-files branch January 17, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated:automerge (Disabled) Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants